From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C3C32A3EC for ; Mon, 10 Aug 2026 15:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786377215; cv=none; b=i6TfJ1Rt0jmMNPaehn9F0zsZSUTXYnBzVUYmR0v36eHBZb4VdFLzOtCOApVIT56Ng8N2md1acAaRdnVH4dtN6IdgFGenqmHTnH8PtZBwjxcgRcucrHHzgF7CC9gOeac7LwOqMUuMn8Rcxduuh8wBjzbFICH/qrrU5wZh4AGdXx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786377215; c=relaxed/simple; bh=Ro0N5PxSzkcGfaO2q/mC90NvWjxKhBcpNAXq9iivlfY=; h=Message-ID:Subject:From:To:Cc:In-Reply-To:References:Content-Type: Date:MIME-Version; b=TAD+gFqiVz1f5OFAGohBlqIZ79ZxP3ZXTQe0jXtLiPj12erH0rlC5Wng5BFsKYEFT16CYCQ+4KPfTlICW/F8vnzAAtsuuTSRgesq1f7U+5/QA6aExVAhdQqnsJhLZefIdL2mjzVAdU53nV9n+CNWzyIZOyXVgmL6wSRKdbucmgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RT+OA4U5; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RT+OA4U5" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c20ce3c118aso6536866b.0 for ; Mon, 10 Aug 2026 08:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786377212; x=1786982012; darn=vger.kernel.org; h=user-agent:mime-version:date:content-transfer-encoding:content-type :references:in-reply-to:cc:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=uZhcRyQnA3+vAWSpQZGi/HC8GMXRR5Rr60F2e5thEwg=; b=RT+OA4U5/7tLyre4qZ86ziuaIsqXwkP0Ur9dH1tflt0XuIriW2DUyPXDCfDFPyiw+Z L1BFOkg1b8YR0+xyX47osdKB0AWBiT0yAAcCQQmPf3Irn7gKoRneKAoZLHbNApBvkBNt MCxUDCXZ6fPherp9DZAB42SG+Cn/VLM0AyczUZ3briCIYjRlKvosaAw6EqubJZ/b7utK jaaf0j/dWUwPxxFHXqqe0veKcbZE/C64pS2KDC0IeXK1KIkCmk+Rz+1Rb6y7NHmpQGjt NS/uIJv9BU7lr/+rrtlv94ZVi+OJh2O+900u1Q+TsEDkcMT1zOSxlSkNHd1vXuCNN4s3 MpeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786377212; x=1786982012; h=user-agent:mime-version:date:content-transfer-encoding:content-type :references:in-reply-to:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uZhcRyQnA3+vAWSpQZGi/HC8GMXRR5Rr60F2e5thEwg=; b=POIhuJ10BItRditv0f20/39r76l+QjiRV1836Zn1lqycM7CPZlkeysRw9/qO4dN72Y fjJhcrU4RdSKedy5vULaRj0p6CEEXVWK8MlDBpsNjAVwnuPMuQ3OQ344+0Grvcj42GDr pZ2xYxy3msufO1dEwsrYDvGGJyKR2k+vKBgUTvLt0pPWPJYq8o7zt3R8FEdRBKv4ab2x j1ElEUTq9m3u0UquuI3v5wX7IHe2Ls+EfwOTIfqiUmSC20jqrKfKwVwCFZbeI5hgA364 0LQ+TrvKMyI2YiiqRyAKqiQRiyYFoiDRmEDxuKQiV7Cy2fewQgikPaI9Vc+HoUhzBSin msuQ== X-Forwarded-Encrypted: i=1; AHgh+RoQOISV9A1cSSkn54r6+qstfdFRtFYSns2AH5H+uaL83hagJ7E+3ju3QGZIDNC5SkScKSicEEvUG2+qtQY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9/mxQMOq6qDOKR+M4Nw+d/MOEFUWdxYao7+fD1G0eU9liYaOG SUGcw4uZrWusmOmHKYeGr9/3weajIuQXKCg3hzfRyqP3pZ4rfqL1Q+QVzAe0NlyIZgk= X-Gm-Gg: AR+sD12eLvSjIc8K3Dd7aUKzLsyEMrCInLjYvvxpgBT6ijGKu97W1wEMxtJI+UrADFo Z2+zySeiVAcTdzh3OBVfsZd5mC8o4sQcogpOd27BnA0N/DJ86nLRN+vkHrpPSLNmHyOHj3mFsu/ WnRN2ZG6kM9WJkFaFw/KylBbHjvAZpP7e4eF3zyM7aoa7xAQ4eSiYCFVRvHt2yw8I93hj9AqYOf SExtF2EmIT+adOFJl5iXNdCQRnqzXzx+heKIGPeRYKJxrPr1+Ln6f4hREv0LtyJJwvY95ey2cTv vRUcM9gzXHMo1CP5LvePFQKN1G3fTRBIbygAi+Unj2/a96Nz8byMDB/mjosBWc/Oukc3y1IAXKh 5Ytn3DWWZOWoDEstCN9yIr9q60r+74g8S7PKeDZz55qV2oHwRqagx5cZgAYV0ZcmbB3+7EeM1G7 wyjJ2cWyR8HR0smWSkKOoGvy+0JdI35Y2iFQdQCIFuCRsZ10jGZfW4lOLZwunw7r+EzV1JJjiIG n4aWYsS6jCLSdNhg1nWE6lil60kWVFCquXh9+NdTwlx4Za2PXq/5ZSO X-Received: by 2002:a17:907:a890:b0:c16:aee0:5422 with SMTP id a640c23a62f3a-c208d3d7dfcmr802842966b.6.1786377212359; Mon, 10 Aug 2026 08:53:32 -0700 (PDT) Received: from [10.198.255.130] (polaris.rmrf.org. [70.34.242.93]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a1e7c9d912sm4208903a12.2.2026.08.10.08.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 08:53:32 -0700 (PDT) Message-ID: <6b68d04721562e51e8d26bfb1450b4f9d9e73d2c.camel@gmail.com> Subject: Re: [PATCH v3] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a p/n: AD3Q9ET#UUG From: Denis Batishchev To: Takashi Iwai Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <87tsp2asuv.wl-tiwai@suse.de> References: <20260810151440.2306217-2-ii343hbka@gmail.com> <87tsp2asuv.wl-tiwai@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 10 Aug 2026 17:48:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Evolution 3.56.2-9 Hi Takashi, Thanks for pointing that out and applying it to for-next. I'll pay closer attention next time :) Thanks again, Denis B. On Mon, 2026-08-10 at 17:38 +0200, Takashi Iwai wrote: > On Mon, 10 Aug 2026 17:14:41 +0200, > Denis Batishchev wrote: > >=20 > > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec. > > Without a quirk no fixup is selected and the mic-mute LED stays off. > > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the > > already-supported 14" variant (SSID 103c:8dfb), so add it. > >=20 > > Signed-off-by: Denis Batishchev > > Cc: > > --- > > v2: fix indentation (per Takashi Iwai ) > > v3: fix indentation, 2nd trial (per Takashi Iwai ) > > --- > > sound/hda/codecs/realtek/alc269.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realt= ek/alc269.c > > index 6b36c730c..bcbdafb42 100644 > > --- a/sound/hda/codecs/realtek/alc269.c > > +++ b/sound/hda/codecs/realtek/alc269.c > > @@ -7544,6 +7544,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = =3D { > > SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_H= P_MUTE_LED_MICMUTE_VREF), > > SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP= _GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_H= P_MUTE_LED_MICMUTE_VREF), > > + SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14 (AD3Q9ET#UUG)", = ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > > SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP= _GPIO_LED), > > SND_PCI_QUIRK(0x103c, 0x8e11, "HP Trekker", ALC287_FIXUP_CS35L41_I2C_= 2), > > SND_PCI_QUIRK(0x103c, 0x8e12, "HP Trekker", ALC287_FIXUP_CS35L41_I2C_= 2), >=20 > The table is sorted in PCI SSID order, so it should have been put at > the one entry below; for saving the internet bandwidth, I corrected > locally at applying now :) >=20 > Applied to for-next branch. Thanks. >=20 >=20 > Takashi