From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 4/8] drm/i915/selftests: Remove erroneous intel_engine_pm_put
Date: Mon, 10 Feb 2020 12:09:16 +0000 [thread overview]
Message-ID: <6b7ff87f-a9dc-a97c-997e-165f1a48c44c@linux.intel.com> (raw)
In-Reply-To: <20200209131922.180287-4-chris@chris-wilson.co.uk>
On 09/02/2020 13:19, Chris Wilson wrote:
> On an allocation error path for live_hwsp_alternate, we dropped the
> engine wakeref before we had even acquired it.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/selftest_timeline.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_timeline.c b/drivers/gpu/drm/i915/gt/selftest_timeline.c
> index e59bf7e31d83..c2578a0f2f14 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_timeline.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_timeline.c
> @@ -606,7 +606,6 @@ static int live_hwsp_alternate(void *arg)
>
> tl = checked_intel_timeline_create(gt);
> if (IS_ERR(tl)) {
> - intel_engine_pm_put(engine);
> err = PTR_ERR(tl);
> goto out;
> }
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-10 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 13:19 [Intel-gfx] [PATCH 1/8] drm/i915/execlists: Fix hold/unhold recursion Chris Wilson
2020-02-09 13:19 ` [Intel-gfx] [PATCH 2/8] drm/i915/execlists: Ignore tracek for nop process_csb Chris Wilson
2020-02-09 13:19 ` [Intel-gfx] [PATCH 3/8] drm/i915/selftests: Exercise timeslice rewinding Chris Wilson
2020-02-09 13:19 ` [Intel-gfx] [PATCH 4/8] drm/i915/selftests: Remove erroneous intel_engine_pm_put Chris Wilson
2020-02-10 12:09 ` Tvrtko Ursulin [this message]
2020-02-09 13:19 ` [Intel-gfx] [PATCH 5/8] drm/i915/selftests: Relax timeout for error-interrupt reset processing Chris Wilson
2020-02-09 13:19 ` [Intel-gfx] [PATCH 6/8] drm/i915/gem: Don't leak non-persistent requests on changing engines Chris Wilson
2020-02-09 13:19 ` [Intel-gfx] [PATCH 7/8] drm/i915: Disable use of hwsp_cacheline for kernel_context Chris Wilson
2020-02-09 13:19 ` [Intel-gfx] [PATCH 8/8] drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore Chris Wilson
2020-02-09 13:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915/execlists: Fix hold/unhold recursion Patchwork
2020-02-09 14:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-10 12:04 ` [Intel-gfx] [PATCH 1/8] " Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7ff87f-a9dc-a97c-997e-165f1a48c44c@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.