From: Christian Lamparter <chunkeey@gmail.com>
To: Dmitry Antipov <dmantipov@yandex.ru>,
Fedor Pchelkin <pchelkin@ispras.ru>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: carl9170: do not ping device which has failed to load firmware
Date: Mon, 16 Jun 2025 18:55:54 +0200 [thread overview]
Message-ID: <6bacdb9c-6064-43ea-9dfe-0eca496d1c9b@gmail.com> (raw)
In-Reply-To: <70de6013-a5db-45c6-8288-e7b211a55a1e@yandex.ru>
Hi,
On 6/16/25 12:01 PM, Dmitry Antipov wrote:
> On 6/15/25 10:54 PM, Fedor Pchelkin wrote:
>
>> So it looks like ar->registered being false here is a "correct" failure
>> condition, i.e. it can be expected when the certain phase of the driver
>> initialization fails and should be handled without any WARNs.
>
> Looking through Documentation/process/coding-style.rst, it may be
> better to use pr_warn_once() instead; anyway I would prefer leave
> the final decision to the maintainer.
Sure. I think you made a fine point. Grepping through drivers/net/wireless
in the (wireless-testing wt-2025-06-08-24) it seems that this could be the
first pr_warn_once in there.
@Dmitry, would you please respin the patch? Thank you!
Regards,
Christian
next prev parent reply other threads:[~2025-06-16 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 10:02 [PATCH] wifi: carl9170: do not ping device which has failed to load firmware Dmitry Antipov
2025-06-11 20:36 ` Christian Lamparter
2025-06-15 19:54 ` Fedor Pchelkin
2025-06-16 10:01 ` Dmitry Antipov
2025-06-16 16:55 ` Christian Lamparter [this message]
2025-06-16 18:12 ` [PATCH v2] " Dmitry Antipov
2025-06-17 6:18 ` Christian Lamparter
2025-06-17 23:32 ` Jeff Johnson
-- strict thread matches above, loose matches on Subject: below --
2025-06-13 20:19 [PATCH] " Fedor Pchelkin
2025-06-14 16:33 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bacdb9c-6064-43ea-9dfe-0eca496d1c9b@gmail.com \
--to=chunkeey@gmail.com \
--cc=dmantipov@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pchelkin@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.