Re: [PATCH v2 08/10] drm/i915: Nuke HAS_FPGA_DBG_UNCLAIMED()/.has_fpga_dbg

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 10 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> HAS_FPGA_DBG_UNCLAIMED() and the underlying .has_fpga_dbg device
> flag is now unused. Nuke it all.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 8 --------
>  drivers/gpu/drm/i915/display/intel_display_device.h | 2 --
>  2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 69046d0cd5e9..055396f85e4a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -571,7 +571,6 @@ static const struct platform_desc hsw_desc = {
>  	.info = &(const struct intel_display_device_info) {
>  		.has_ddi = 1,
>  		.has_dp_mst = 1,
> -		.has_fpga_dbg = 1,
>  		.has_hotplug = 1,
>  		.has_psr = 1,
>  		.has_psr_hw_tracking = 1,
> @@ -624,7 +623,6 @@ static const struct platform_desc bdw_desc = {
>  	.info = &(const struct intel_display_device_info) {
>  		.has_ddi = 1,
>  		.has_dp_mst = 1,
> -		.has_fpga_dbg = 1,
>  		.has_hotplug = 1,
>  		.has_psr = 1,
>  		.has_psr_hw_tracking = 1,
> @@ -665,7 +663,6 @@ static const struct intel_display_device_info skl_display = {
>  	.dbuf.slice_mask = BIT(DBUF_S1),
>  	.has_ddi = 1,
>  	.has_dp_mst = 1,
> -	.has_fpga_dbg = 1,
>  	.has_hotplug = 1,
>  	.has_ipc = 1,
>  	.has_psr = 1,
> @@ -815,7 +812,6 @@ static const struct platform_desc cml_desc = {
>  	.dbuf.slice_mask = BIT(DBUF_S1), \
>  	.has_dp_mst = 1, \
>  	.has_ddi = 1, \
> -	.has_fpga_dbg = 1, \
>  	.has_hotplug = 1, \
>  	.has_ipc = 1, \
>  	.has_psr = 1, \
> @@ -874,7 +870,6 @@ static const struct platform_desc glk_desc = {
>  	.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2), \
>  	.has_ddi = 1, \
>  	.has_dp_mst = 1, \
> -	.has_fpga_dbg = 1, \
>  	.has_hotplug = 1, \
>  	.has_ipc = 1, \
>  	.has_psr = 1, \
> @@ -965,7 +960,6 @@ static const struct platform_desc ehl_desc = {
>  	.has_ddi = 1, \
>  	.has_dp_mst = 1, \
>  	.has_dsb = 1, \
> -	.has_fpga_dbg = 1, \
>  	.has_hotplug = 1, \
>  	.has_ipc = 1, \
>  	.has_psr = 1, \
> @@ -1133,7 +1127,6 @@ static const struct platform_desc adl_s_desc = {
>  	.has_ddi = 1,								\
>  	.has_dp_mst = 1,							\
>  	.has_dsb = 1,								\
> -	.has_fpga_dbg = 1,							\
>  	.has_hotplug = 1,							\
>  	.has_ipc = 1,								\
>  	.has_psr = 1,								\
> @@ -1313,7 +1306,6 @@ static const struct platform_desc dg2_desc = {
>  	.has_ddi = 1,								\
>  	.has_dp_mst = 1,							\
>  	.has_dsb = 1,								\
> -	.has_fpga_dbg = 1,							\
>  	.has_hotplug = 1,							\
>  	.has_ipc = 1,								\
>  	.has_psr = 1,								\
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 7121e7cd9512..4f82520ef960 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -134,7 +134,6 @@ struct intel_display_platforms {
>  	func(has_ddi); \
>  	func(has_dp_mst); \
>  	func(has_dsb); \
> -	func(has_fpga_dbg); \
>  	func(has_gmch); \
>  	func(has_hotplug); \
>  	func(has_hti); \
> @@ -177,7 +176,6 @@ struct intel_display_platforms {
>  #define HAS_FBC(__display)		(DISPLAY_RUNTIME_INFO(__display)->fbc_mask != 0)
>  #define HAS_FBC_DIRTY_RECT(__display)	(DISPLAY_VER(__display) >= 30)
>  #define HAS_FBC_SYS_CACHE(__display)	(DISPLAY_VER(__display) >= 35 && !(__display)->platform.dgfx)
> -#define HAS_FPGA_DBG_UNCLAIMED(__display)	(DISPLAY_INFO(__display)->has_fpga_dbg)
>  #define HAS_FW_BLC(__display)		(DISPLAY_VER(__display) >= 3)
>  #define HAS_GMBUS_BURST_READ(__display)	(DISPLAY_VER(__display) >= 10 || (__display)->platform.kabylake)
>  #define HAS_GMBUS_IRQ(__display)	(DISPLAY_VER(__display) >= 4)

-- 
Jani Nikula, Intel