From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95725D3B7E2 for ; Mon, 8 Dec 2025 12:44:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 159E782A9E; Mon, 8 Dec 2025 13:44:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=nabladev.com header.i=@nabladev.com header.b="bGlD/2VU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0BAD783B22; Mon, 8 Dec 2025 10:26:42 +0100 (CET) Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B90AE83AB0 for ; Mon, 8 Dec 2025 10:26:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hs@nabladev.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7E85D106576; Mon, 8 Dec 2025 10:26:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1765185997; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=DadHPPvxq7tWbNDCgnEwl4o08STGp3OkgMXo9aAif8Y=; b=bGlD/2VUOzlNNiY55p59fgGzsfa5CEjGX90TLLIBMz2rUp/7miaKXDZp9t8cqyJUtLyD/w ze05zKJ+WD1GH5fjd3AbzguYs7HQny6VJoUYfq1WtdU9Erx3HlPwJ33SEfaX2RUg3iqTDb ELzjCCJg2tsI06Cro2CqH8fX40GVZrm+Rkjy2sEG1eZoAaLpUDIMZropNa7ZXNOpKYFi9K 1tlNGpKkQR/6qC6SgdbJuAVeGh2P5lPHdXbIirvruCkUyjDCg6Jy5jm4Kqmie49c6J7jss SZc4Aq8rQvS6hBWhQZZ+I+M0sotQLbiofW+sei+3itt8MOS3xT04j1Zx37ABzA== Message-ID: <6bb63d2f-6bf0-3610-940f-6656b104b22d@nabladev.com> Date: Mon, 8 Dec 2025 10:26:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3 0/6] Add support for SM3 secure hash Content-Language: en-US To: Ilias Apalodimas , Tom Rini Cc: U-Boot Mailing List , Alif Zakuan Yuslaimi , Andrew Goodbody , Anshul Dalal , Arturs Artamonovs , Casey Connolly , Dinesh Maniyam , Greg Malysa , Heinrich Schuchardt , Ibai Erkiaga , Jaehoon Chung , Jerome Forissier , "Kory Maincent (TI.com)" , Marek Vasut , Martin Schwan , Mattijs Korpershoek , Michael Trimarchi , Michal Simek , Mikhail Kshevetskiy , Miquel Raynal , Nathan Barrett-Morrison , Oliver Gaskell , Paul Barker , Peng Fan , Peter Robinson , Philippe Reynes , Quentin Schulz , Raymond Mao , Sean Edmond , Simon Glass , Stefan Roese , Sumit Garg , Utsav Agarwal , Vasileios Bimpikas , Venkatesh Yadav Abbarapu , briansune References: <20251118043042.27726-1-hs@nabladev.com> <176487670995.2050783.17410258029578449020.b4-ty@konsulko.com> <6d29ed19-4fd5-afc9-56e2-f4c9df34ff70@nabladev.com> <20251205141116.GH303283@bill-the-cat> From: Heiko Schocher In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-Mailman-Approved-At: Mon, 08 Dec 2025 13:44:18 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Ilias, On 08.12.25 10:07, Ilias Apalodimas wrote: > Heiko, > > I had another look. Oberall the changes seem fine and I don't mind keeping them. > Any chance you tested this on actual hardware? I have here an imx8mp board with tpm chip, and I try to test it soon... sorry for the delay. bye, Heiko > > Cheers > /Ilias > > On Fri, 5 Dec 2025 at 16:11, Tom Rini wrote: >> >> On Fri, Dec 05, 2025 at 09:02:28AM +0100, Heiko Schocher wrote: >>> Hello Ilias, >>> >>> On 05.12.25 08:24, Ilias Apalodimas wrote: >>>> On Fri, 5 Dec 2025 at 07:03, Heiko Schocher wrote: >>>>> >>>>> Hello Tom, >>>>> >>>>> On 04.12.25 20:31, Tom Rini wrote: >>>>>> On Tue, 18 Nov 2025 05:30:36 +0100, Heiko Schocher wrote: >>>>>> >>>>>>> Add SM3 secure hash, as specified by OSCCA GM/T 0004-2012 SM3 and described >>>>>>> at https://datatracker.ietf.org/doc/html/draft-sca-cfrg-sm3-02 >>>>>>> >>>>>>> TPMv2 defines hash algo sm3_256, which is currently >>>>>>> not supported and prevented TPMv2 chip with newer >>>>>>> firmware to work with U-Boot. Seen this on a ST33TPHF2XI2C >>>>>>> >>>>>>> [...] >>>>>> >>>>>> Applied to u-boot/next, thanks! >>>>>> >>>>>> [1/6] lib: Import rol32 function from Linux >>>>>> commit: 6a0c939b88fd42c6b0a374f7c87317f292df46a1 >>>>>> [2/6] lib: import sm3 256 hash parts from linux >>>>>> commit: 41c0131b950a16747929ab310588cf5db8e38123 >>>>>> [3/6] lib: sm3: implement U-Boot parts >>>>>> commit: c4ab316269debc321907acc4f8f02dfe5653aeaf >>>>>> [4/6] test: cmd: hash: add unit test for sm3_256 >>>>>> commit: 213601a600f1e8894cea76b0bfc131f038882407 >>>>>> [5/6] tpm2: add sm3 256 hash support >>>>>> commit: 7c3f05ad51e4bc23dd4f411f28968f1d8f43099c >>>>>> [6/6] test: cmd: fix a typo in md5 test >>>>>> commit: b30557b3b46c5162cb88a57907c517ed95557239 >>>>> >>>>> Oh, may a little to fast, as Ilias and Quentin had some comments >>>>> about tpm2 implementation/test (tpm2: add sm3 256 hash support >>>>> patch). But I can send changes on top of that patches (but >>>>> give me some time for it... end of year rally has started...) >>>>> >>>> >>>> Yea I pinged Tom yesterday. >>>> tbh, my main concern was testing the changes. I dont mind if we revert >>>> and reapply or send the changes on top. >>> >>> I am fine with sending updates on top. >> >> Sorry for getting ahead of everyone else here, since it sounds like >> everyone is OK with updates on top, we can move forward. Thanks! >> >> -- >> Tom -- Nabla Software Engineering HRB 40522 Augsburg Phone: +49 821 45592596 E-Mail: office@nabladev.com Geschäftsführer : Stefano Babic