From: John Garry <john.garry@linux.dev>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 4/8] scsi: scsi_debug: Split resp_read_dt0()
Date: Mon, 12 Oct 2026 18:18:32 +0100 [thread overview]
Message-ID: <6bd7fafe-23b0-41f5-bfa8-5cbfd1ce38a6@linux.dev> (raw)
In-Reply-To: <5336162520371fc22ebde7bd4080a9465908dd2a.1791499174.git.bvanassche@acm.org>
On 10/8/26 23:42, Bart Van Assche wrote:
Reviewed-by: John Garry <john.garry@linux.dev>
> + ret = __resp_read_dt0(scp, sip, lba, num, ei_lba, &scsi_status);
> + sdeb_meta_read_unlock(sip);
> + } else {
> + ret = __resp_read_dt0(scp, sip, lba, num, ei_lba, &scsi_status);
> }
>
> - ret = do_device_access(sip, scp, 0, lba, num, 0, false, false);
> - if (meta_data_locked)
> - sdeb_meta_read_unlock(sip);
> if (unlikely(ret == -1))
I think that ret < 0 is a better check, but this is pre-existing code
and this is not too important.
> - return DID_ERROR << 16;
> + return scsi_status;
next prev parent reply other threads:[~2026-10-12 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 22:42 [PATCH v5 0/8] scsi_debug: Enable lock context analysis Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 1/8] scsi: scsi_debug: Fix a locking bug in resp_write_same() Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 2/8] scsi: scsi_debug: Split resp_write_same() Bart Van Assche
2026-10-08 22:52 ` sashiko-bot
2026-10-08 23:27 ` Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 3/8] scsi: scsi_debug: Split corrupt_lbas() Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 4/8] scsi: scsi_debug: Split resp_read_dt0() Bart Van Assche
2026-10-12 12:23 ` Christoph Hellwig
2026-10-12 17:18 ` John Garry [this message]
2026-10-08 22:42 ` [PATCH v5 5/8] scsi: scsi_debug: Split resp_write_dt0() Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 6/8] scsi: scsi_debug: Split resp_atomic_write() Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 7/8] scsi: scsi_debug: Improve lock context annotations Bart Van Assche
2026-10-12 12:24 ` Christoph Hellwig
2026-10-12 15:31 ` Bart Van Assche
2026-10-08 22:42 ` [PATCH v5 8/8] scsi: core: Enable lock context analysis for the scsi_debug driver Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bd7fafe-23b0-41f5-bfa8-5cbfd1ce38a6@linux.dev \
--to=john.garry@linux.dev \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.