From: m.brock@vanmierlo.com
To: Florian Eckert <fe@dev.tdt.de>
Cc: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
kabel@kernel.org, u.kleine-koenig@pengutronix.de,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
Date: Sat, 04 Nov 2023 14:25:51 +0100 [thread overview]
Message-ID: <6be2d8101fb8da3455974ead01721e7e@vanmierlo.com> (raw)
In-Reply-To: <20231030100447.63477-4-fe@dev.tdt.de>
Florian Eckert wrote on 2023-10-30 11:04:
> The ttyname buffer for the ledtrig_tty_data struct is allocated in the
> sysfs ttyname_store() function. This buffer must be released on trigger
> deactivation. This was missing and is thus a memory leak.
Shouldn´t there be a Fixes tag here?
And as a side note: you have patches 1..7/7 and a cover letter 0/8 ?
Maarten
next prev parent reply other threads:[~2023-11-04 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 10:04 [Patch v6 0/8] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-30 10:04 ` [Patch v6 1/7] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-30 10:04 ` [Patch v6 2/7] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-30 10:04 ` [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer on deactivate Florian Eckert
2023-11-04 13:25 ` m.brock [this message]
2023-10-30 10:04 ` [Patch v6 4/7] leds: ledtrig-tty: change logging if get icount failed Florian Eckert
2023-10-30 10:04 ` [Patch v6 5/7] leds: ledtrig-tty: replace mutex with completion Florian Eckert
2023-10-30 10:04 ` [Patch v6 6/7] leds: ledtrig-tty: make rx tx activitate configurable Florian Eckert
2023-10-30 10:04 ` [Patch v6 7/7] leds: ledtrig-tty: add additional line state evaluation Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be2d8101fb8da3455974ead01721e7e@vanmierlo.com \
--to=m.brock@vanmierlo.com \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.