From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>,
broonie@kernel.org, kuninori.morimoto.gx@renesas.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: simple-card-utils: Add support of "hp-pin-name-headphone" property
Date: Mon, 29 Dec 2025 12:43:04 +0100 [thread overview]
Message-ID: <6bfbce03-e58d-4468-8d9d-822bd8ee75d6@kernel.org> (raw)
In-Reply-To: <20251229111839.4009517-3-shengjiu.wang@nxp.com>
On 29/12/2025 12:18, Shengjiu Wang wrote:
> The 'Headphones Jack' name used in current simple-card and audio-graph
> card driver can't be recognized by user space service daemon like
> pulseaudio and pipewire, which only recognize the 'Headphone Jack',
> so add 'hp-pin-name-headphone' property for this case and it won't block
> original use cases for 'Headphones Jack'
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> sound/soc/generic/simple-card-utils.c | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index bdc02e85b089..3d2194e23373 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -779,6 +779,24 @@ int simple_util_parse_pin_switches(struct snd_soc_card *card,
> }
> EXPORT_SYMBOL_GPL(simple_util_parse_pin_switches);
>
> +static const char *simple_util_parse_hp_pin_name(struct snd_soc_card *card,
> + char *prefix, char *pin)
> +{
> + struct device_node *node = card->dev->of_node;
> + const char *str = NULL;
> + char prop[128];
> +
> + if (!prefix)
> + prefix = "";
> +
> + snprintf(prop, sizeof(prop), "%s%s", prefix, "hp-pin-name-headphone");
> +
That's different name than you defined in the bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-29 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 11:18 [PATCH 0/2] ASoC: simple-card: add 'hp-pin-name-headphone' property Shengjiu Wang
2025-12-29 11:18 ` [PATCH 1/2] ASoC: dt-bindings: " Shengjiu Wang
2025-12-29 11:41 ` Krzysztof Kozlowski
2025-12-29 11:18 ` [PATCH 2/2] ASoC: simple-card-utils: Add support of "hp-pin-name-headphone" property Shengjiu Wang
2025-12-29 11:43 ` Krzysztof Kozlowski [this message]
2026-01-06 7:58 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bfbce03-e58d-4468-8d9d-822bd8ee75d6@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.