All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: dsahern@gmail.com, stephen@networkplumber.org,
	davem@davemloft.net, kuba@kernel.org, mlxsw@mellanox.com
Subject: Re: [patch iproute2/net-next] devlink: fix JSON output of mon command
Date: Mon, 6 Apr 2020 11:43:48 -0700	[thread overview]
Message-ID: <6c15c9ec-e1e3-cf78-e2bb-9c5db8d43abc@intel.com> (raw)
In-Reply-To: <20200402095608.18704-1-jiri@resnulli.us>



On 4/2/2020 2:56 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> The current JSON output of mon command is broken. Fix it and make sure
> that the output is a valid JSON. Also, handle SIGINT gracefully to allow
> to end the JSON properly.
> 

I wonder if there is an easy way we could get "make check" or something
to add a test to help verify this is valid JSON?

Thanks,
Jake

  reply	other threads:[~2020-04-06 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  9:56 [patch iproute2/net-next] devlink: fix JSON output of mon command Jiri Pirko
2020-04-06 18:43 ` Jacob Keller [this message]
2020-04-06 20:28   ` Petr Machata
2020-04-06 22:48     ` Stephen Hemminger
2020-04-07  9:09 ` Jiri Pirko
2020-04-09 14:43 ` David Ahern
2020-04-09 18:28   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c15c9ec-e1e3-cf78-e2bb-9c5db8d43abc@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.