From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F734AA3F8 for ; Fri, 11 Sep 2026 17:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148034; cv=none; b=PrpShPLhpmhtb6aa7UU/6hhHKCO/mgrXw+n2YIHOL0QGNKIiNVR0B9gXTgNp0hmwgRQy5pg+qYiBghJROmmcwzwKp5/bV0YZeMFd6mo7H4ACYrH2tuGLk4W+J8q5rQopjgZKi+1dxg7DBmxp3FuEEhdlXj615L7V0Cp6dxSegmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148034; c=relaxed/simple; bh=EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y4hsP6guiMTeiOoBRYStmyPs0qt99w1kY5eyfxi7XB11bZdCQ1vHyEj2t3dBCnOZ7SRfVCsHM4ilYxpLSbl2ZbPQF3/ssoGvk0VH5yygZf0XjPsAXCJd6ynLHaYwDI34cLQBBmSY8o5+r0BN8Axrvt7qAWx3Ki7dpkd0FZYzlFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cc/b+z6x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZdQh8S4O; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cc/b+z6x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZdQh8S4O" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68BHW3NF639413 for ; Fri, 11 Sep 2026 17:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; b=cc/b+z6x51RqC4LR +sEC5aT9eXjCvmigj+mJVB7E4YMABRFH0qxeo8tng4VITpnJtyi2DTEFxcxdHtp+ Z/TMZKgb7RUG9Ysd6wln2/M0fwunLiU9RH8GMf4K6kHDQmLUR/7HSLe2wMlUh4e7 bPyyeWzllqme2cw0df9qRe3HWT/mzLgUvbSsapvB5zE/Ayo70PPEWsad+vxBJ9Ex DIHlg5TNaU1s4/WSLwdBaOp6LStNMUpL9Te1UJE7n1Xo2VIgdcOi15JY/UXkq1RG 07kggEPNWEvfgkWR0yN5/brxtxfcss29TeSBJkkhyiAR9Sw7Ow3y2SfJdDbTLFiM DbY4wA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmp4cr0ac-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 17:33:47 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38ec0f510a9so2193573a91.2 for ; Fri, 11 Sep 2026 10:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789148027; x=1789752827; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; b=ZdQh8S4ORZu7O5ekv8y3hjYdmyOtf1eONoKDhim+GdJ9vxluas5uu0an0PLTa/EJ9a llNJ+8Ky7HJnw11XVWvUBmwpJjsooBIRY/sEkFX4tilwkjt9/3WfXvHpQ/KwwPRtnKbl 7MYaxn1EU7R+EJSzm1HEsMk9AH/bGjgrRkuGnDycwGvRSR7/lmJmckXGLayCUPicGyb2 +VusMOL6/shlKbsJLezTccFbvvLF7mJcbvRhEpzkAZqB1gSKn5QP5nhSnz0WZU8gZTYc u4LwMNK3MbPTaEhsf/HOkdQror8vI1M4ODA910Z3f8EXBX3jAC82wYblVUN0iGjHUtmI F01A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789148027; x=1789752827; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; b=YFB3UlavlKFX+GLJtI92p4S3JWMEq77f0UYKPrBvTNy6TvFC+SWErMM08frY2/jVIR YqwuKlq7LIaZRvebLzp3Z9u5A0c6FZzxCNjrriI/d7+Shrqj2ChFeZ/Ma8HT5Ny4xBWr l0oB5zVA9Q018guD4b2WVCHsoMN1WSVTOPc62Xa7VWWtV+Uvzio2dKZrPmLb5peydWGh HdO5OcIHm4c0drRtg5sMaE51HXKgKO08Z9jTkqU1D/15qo/aKcNHzhe9k7JuPZiVq0Jv Ua0ySC2vK++1eOo3oYSfPUsSMSRGJvYFIaRWUGhz5GRCOmN5AGLNz9N09623gDVpQFwU E94g== X-Forwarded-Encrypted: i=1; AKwUvBynrU3KOsWTzSB0g130fDozjEsxE1ETK+oZigQ3jet2yH/FQc7Pnk20CVCr5qkJnDjBP3nbHWYVrw==@vger.kernel.org X-Gm-Message-State: AFuF++lCyuxYGOmfBcF+fRp6z5NRfgx6ZQU77nzhmQyk9bBVoCeTpmYB J4oC/WkV1Bb8N7RV3YgvRMHHtC51L/tTDfZJdBH+6/nvQT8vXmWMk7m1LbvJrjmrQH01zLx8Wkk u5gJuWlH+7jIzHnUkGE5+OMGA1LhLMAd2S+ns38k7phyBrDRBDyVvNiuo0TWwLw== X-Gm-Gg: AYBFou3Hla30dcouNIVBBiVgFlvleLBD/agoeQFLTQ2DqDIPdwagcaBxDR8u8jmKW71 j0vGHNbPkDKHLaBh/ETtkzfAT1RphxD8PgkyBGHv1pZCk/DeeYOFtVcMd8Ubl/T6vhR6l1GJ3aa +2tkEJZJRFmMCR37d2p4wBps1U85myxh5YksaYGV/LfVTU1tbKCBKjFw7vGLw4v16KDnndnbzjE hz176lOQww/0HUCUjow8bbOoig7DeIVgrmpBQzsj0MsOa7y8roF1YTcCdJy7KpkbSDUbzY/91C5 M2JarlrhBaOGwPBMb7TbdV5iQoLEStLHcmLCLO8nL9KAFReXJkikF3uE3Ryw8ZQ5tKZDtKkHZjg 6P0jzcGSTpgT62l1+I9eazCrBl25MWY36 X-Received: by 2002:a17:90a:da8f:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39d9bbee490mr8584054a91.2.1789148026783; Fri, 11 Sep 2026 10:33:46 -0700 (PDT) X-Received: by 2002:a17:90a:da8f:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39d9bbee490mr8583885a91.2.1789148024735; Fri, 11 Sep 2026 10:33:44 -0700 (PDT) Received: from [192.168.0.6] ([49.204.105.169]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d98a58d23sm6853266a91.2.2026.09.11.10.33.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 10:33:44 -0700 (PDT) Message-ID: <6c28e672-349c-49cb-892d-ec521b3004bf@oss.qualcomm.com> Date: Fri, 11 Sep 2026 23:03:36 +0530 Precedence: bulk X-Mailing-List: arm-scmi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/9] soc: qcom: geni: Derive SE clock configuration from OPP table on SA8255P To: Konrad Dybcio , Ulf Hansson Cc: Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti , mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org, Abel Vesa References: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-0-091697dbeb02@oss.qualcomm.com> <177884a8-902f-49be-8fcb-b2bec3ec7d6c@oss.qualcomm.com> <0f5494c7-c3c1-4668-a09f-d8c43d1c58b9@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <0f5494c7-c3c1-4668-a09f-d8c43d1c58b9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: dIgsC2hrfMrJX10GyMEG4C9PNSvOGRUO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDI0NSBTYWx0ZWRfX4wZZcXV5MOvn xvuYz9YYfWlGY2sfZrIF0acxtmed3w/UWEUllrBWuxlNg+ZvYkFiTEk5WHzCQK899mcVFesIRSa Qpjx5eJZAcC5iWrfJ1xXLXmgEHbrjJNXsGHtyvPzTrCldWyfzeELf0A35WtbCJGaTYFk2xAwBE4 /8Oj+dC8M5bNh6lG4oP8L+EWQBigokvEw84nxtJpguO/Czp+N2M6q+xiffvZKkeHrnvHrN5PIy+ Tbgt14d2T1HhnUWwbLZ4+6XuqCh61NIUROzloV5QihCN+u4qQJInij9JoF9+kI0qT6WrK8qf0DR 4vSIAKibACSpTu3zxgw8Y6AV2Hmkc8uSsngOqgZdx8U6IAgU8pi9tA84ansikB61L2+qoTaetHH CSW1c0NLEo50V/n4Zxy++uPjmr6N6kCGvEJ6E/lkamJb0Uvx3sDkpBeccxKTC8RzOLhip9OyFsY 5lQbNhyxHAofpVE3mrQ== X-Proofpoint-GUID: dIgsC2hrfMrJX10GyMEG4C9PNSvOGRUO X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDI0NSBTYWx0ZWRfX/UMpMp25kdGX XeoA74RIQGAYoieYoX5Ba87anS66kBDx0JXmm0bviF/mIcDewsu88UnTmkZK/cHHTbGJ+SsB3OY HTsO3CYg2Hh1VbiSZwQvlWFqUBxTOUI= X-Authority-Analysis: v=2.4 cv=KobYSmWN c=1 sm=1 tr=0 ts=6aa43b7b cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=KFINdI5Z0390/lZYonNNQw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=iiE2cmy92MJpIBaOhi4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_06,2026-09-11_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110245 Hi Konrad, On 04-09-2026 14:30, Konrad Dybcio wrote: > On 9/4/26 9:56 AM, Ulf Hansson wrote: >> On Tue, Sep 1, 2026 at 6:48 PM Praveen Talari >> wrote: > [...] > >> So geni_se_clk_freq_match() is used by two consumer drivers today, >> drivers/spi/spi-geni-qcom.c and drivers/tty/serial/qcom_geni_serial.c. >> >> Beyond the $subject series, there will be even more consumer drivers >> that call these platform specific functions. As I said above, I don't >> think this is moving things in the right direction. >> >> If this can't be solved with generic frameworks (clocks and OPP), >> please clarify why so we can figure out a better way forward. > The way I read it, isn't geni_se_clk_freq_match() more or less > dev_pm_opp_find_freq_exact() called in a loop with an increasing > divider? Currently, geni_se_clk_freq_match() relies on clk_perf_tbl to determine the source clock index and divider corresponding to a requested frequency. On Linux-managed platforms, clk_perf_tbl is populated by geni_se_clk_tbl_get(), which enumerates the supported source clock frequencies using clk_round_rate(). int geni_se_clk_freq_match(struct geni_se *se, unsigned long req_freq,                unsigned int *index, unsigned long *res_freq,                bool exact) {     [...]     num_clk_levels = geni_se_clk_tbl_get(se, &tbl);     if (num_clk_levels < 0)         return num_clk_levels;     [...]     best_delta = ULONG_MAX;     for (i = 0; i < num_clk_levels; i++) {         divider = DIV_ROUND_UP(tbl[i], req_freq);         new_delta = req_freq - tbl[i] / divider;         if (new_delta < best_delta) {             /* We have a new best! */             *index = i;             *res_freq = tbl[i];             /* If the new best is exact then we're done */             if (new_delta == 0)                 return 0;             /* Record how close we got */             best_delta = new_delta;         }     } [...]     return 0; } On firmware-managed platforms, clk_perf_tbl is populated from the performance-domain OPP table during domain attachment, allowing geni_se_clk_freq_match() to operate on the same source clock frequency information irrespective of how the underlying resources are managed. As a result, the frequency matching logic, including source clock selection and divider calculation, remains common across both Linux-managed and firmware-managed configurations, while only the mechanism used to apply the selected rate differs. Thanks, Praveen Talari > > Konrad