Re: [PATCH] configure.ac: avoid bashisms

[Avnish Chouhan <avnish@linux.ibm.com>]

On 2025-10-30 17:51, grub-devel-request@gnu.org wrote:
> Message: 2
> Date: Thu, 30 Oct 2025 07:31:59 +0100
> From: Lars Wendler <polynomial-c@gmx.de>
> To: grub-devel@gnu.org
> Cc: Lars Wendler <polynomial-c@gmx.de>
> Subject: [PATCH] configure.ac: avoid bashisms
> Message-ID: <20251030063159.11177-1-polynomial-c@gmx.de>
> Content-Type: text/plain; charset=UTF-8
> 
> or else configure check doesn't succeed with non-bash shell (e.g. 
> dash):
> 
>   checking whether to enable AMD64 as(1) feature detection...
> /var/tmp/portage/sys-boot/grub-2.14_rc1/work/grub-2.14~rc1/configure:
> 39176: test: xx86_64: unexpected operator
>   no
> 
> and later build fails with
> 
> 
> /var/tmp/portage/sys-boot/grub-2.14_rc1/work/grub-2.14~rc1/grub-core/lib/libgcrypt-grub/src/hwf-x86.c:
> In function ‘detect_x86_gnuc’:
> 
> /var/tmp/portage/sys-boot/grub-2.14_rc1/work/grub-2.14~rc1/grub-core/lib/libgcrypt-grub/src/hwf-x86.c:252:17:
> error: ‘HWF_INTEL_CPU’ undeclared (first use in this function)
>     252 |       result |= HWF_INTEL_CPU;
>         |                 ^~~~~~~~~~~~~
> 
> and other corresponding HWF_INTEL_* definitions because 
> HAVE_CPU_ARCH_X86 was
> erroneously not defined by configure script.
> 
> Signed-off-by: Lars Wendler <polynomial-c@gmx.de>
> ---

Reviewed-by: Avnish Chouhan <avnish@linux.ibm.com>

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel