From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] intel: properly test for HAS_LLC Date: Sat, 01 Sep 2012 08:58:55 +0100 Message-ID: <6c3329$5pid8t@orsmga002.jf.intel.com> References: <1346404733-25372-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C8449EB37 for ; Sat, 1 Sep 2012 00:59:20 -0700 (PDT) In-Reply-To: <1346404733-25372-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Fri, 31 Aug 2012 11:18:53 +0200, Daniel Vetter wrote: > If the kernel supports the test, we need to check the param. > Copy&pasta from the above checks that only look at the return value. > Interesting how much one can get such a simple interface wrong. Interesting, didn't realise libdrm declared that we even had LLC on 8xx! Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre