From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] intel: Mark bo's exported to prime as not reusable Date: Fri, 14 Sep 2012 22:03:41 +0100 Message-ID: <6c3329$62mgcc@orsmga002.jf.intel.com> References: <1347655073-15167-1-git-send-email-krh@bitplanet.net> <275ffc$6jt9i1@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0040896947==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 516E69E803 for ; Fri, 14 Sep 2012 14:03:57 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0040896947== Content-Type: text/plain On Fri, 14 Sep 2012 17:01:18 -0400, Kristian Høgsberg wrote: > On Fri, Sep 14, 2012 at 4:40 PM, Chris Wilson wrote: > > On Fri, 14 Sep 2012 16:37:53 -0400, Kristian Høgsberg wrote: > >> It's the same situation as flink and we need take the same pre-cautions. > >> --- > >> intel/intel_bufmgr_gem.c | 8 +++++++- > >> 1 file changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c > >> index 3bcc849..92c0444 100644 > >> --- a/intel/intel_bufmgr_gem.c > >> +++ b/intel/intel_bufmgr_gem.c > >> @@ -2472,8 +2472,14 @@ drm_intel_bo_gem_export_to_prime(drm_intel_bo *bo, int *prime_fd) > >> { > >> drm_intel_bufmgr_gem *bufmgr_gem = (drm_intel_bufmgr_gem *) bo->bufmgr; > >> drm_intel_bo_gem *bo_gem = (drm_intel_bo_gem *) bo; > >> + int ret; > >> > >> - return drmPrimeHandleToFD(bufmgr_gem->fd, bo_gem->gem_handle, DRM_CLOEXEC, prime_fd); > >> + ret = drmPrimeHandleToFD(bufmgr_gem->fd, bo_gem->gem_handle, > >> + DRM_CLOEXEC, prime_fd); > >> + if (ret == 0) > >> + bo_gem->reusable = false; > > > > Now that you mention it... > > To be consistent with libdrm_intel, we should return -errno on error; so > > rephrasing this as > > if (ret) > > return -errno; > > > > bo_gem->reusable = false; > > return 0; > > > > would work better. > > Argh, yes, I copy and pasted that from drm_intel_gem_bo_flink() but > edited it away later... with that change, can I add your reviewed-by > and commit? Yes, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============0040896947== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0040896947==--