From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Only insert the mb() before updating the fence parameter
Date: Tue, 09 Oct 2012 12:26:57 +0100 [thread overview]
Message-ID: <6c3329$6lntgg@orsmga002.jf.intel.com> (raw)
In-Reply-To: <CAKMK7uHrZLNcUrG5T5GaEqWMxPAX_FzdNca8+MWi0K0ObTtgbA@mail.gmail.com>
On Tue, 9 Oct 2012 13:14:09 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> One thing I wonder is whether we miss any barrier between the wc
> writes to the ringbuffer and the tail update. If that's the case I
> wonder where all the bug reports are ...
Ditto. I've often wondered how we get away without a wmb() there...
> Last one: Which machines blow up when you drop that mb()?
pnv, though that's the only non-LLC I've been testing with the
incomplete patch so I can't say it is limited to that machine.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-10-09 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 8:38 [PATCH] drm/i915: Only insert the mb() before updating the fence parameter Chris Wilson
2012-10-09 9:54 ` Daniel Vetter
2012-10-09 10:02 ` Daniel Vetter
2012-10-09 11:03 ` Chris Wilson
2012-10-09 11:14 ` Daniel Vetter
2012-10-09 11:26 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$6lntgg@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.