From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper
Date: Tue, 09 Oct 2012 23:16:02 +0100 [thread overview]
Message-ID: <6c3329$6m595h@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1349815848-1824-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 9 Oct 2012 22:50:48 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The obj->pages to obj->pages->sgl rework introduced this helper, but
> it doesn't actually work for n >= SG_MAX_SINGLE_ALLOC.
>
> For simplicity (and since right now I seem to be too stupid to see
> the bug), let's just grab the right page with a for_each_sg loop.
>
> This is exercised by the improved hangman tests and the gem_exec_big
> test in i-g-t.
>
> v2: Compared to v1, don't try to be clever since I seemingly only
> manage to prove that I'm not clever.
Only I expect that loop to show up on profiles even higher than the
sg_next() from pwrite. :|
I expect it to have a measureable impact upon relocation throughput,
so I should measure it...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-09 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 17:59 [PATCH] drm/i915: fixup i915_gem_object_get_page inline helper Daniel Vetter
2012-10-09 20:41 ` Chris Wilson
2012-10-09 20:50 ` Daniel Vetter
2012-10-09 22:16 ` Chris Wilson [this message]
2012-10-10 9:01 ` Chris Wilson
2012-10-10 9:15 ` Daniel Vetter
2012-10-10 9:21 ` Daniel Vetter
2012-10-10 10:36 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2012-10-10 11:11 Chris Wilson
2012-10-10 11:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$6m595h@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.