From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915/dp: actually nack test request Date: Tue, 23 Oct 2012 10:53:07 +0100 Message-ID: <6c3329$6sard9@orsmga002.jf.intel.com> References: <1350760385-16634-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D97C9F376 for ; Tue, 23 Oct 2012 02:53:37 -0700 (PDT) In-Reply-To: <1350760385-16634-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter wrote: > ... like the comment says. No idea whether this has any effect, but > I guess it's better to not lie to the display by acking a test request > and never following through with it. > > Signed-off-by: Daniel Vetter Ha, if I've learnt anything by now making the code consistent with the comments inside intel_dp.c only leads to pain... Reviewed-by: Chris Wilson But really this needs an ack by Jesse: commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a Author: Jesse Barnes Date: Thu Oct 20 15:09:17 2011 -0700 drm/i915: add DP test request handling DPCD 1.1+ adds some automated test infrastructure support. Add support for reading the IRQ source and jumping to a test handling routine if needed. Subsequent patches will handle particular tests; this patch just ACKs any requested tests by default. -Chris -- Chris Wilson, Intel Open Source Technology Centre