From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2 Date: Tue, 30 Oct 2012 21:32:17 +0000 Message-ID: <6c3329$6vu319@orsmga002.jf.intel.com> References: <1351271318-3148-1-git-send-email-jbarnes@virtuousgeek.org> <1351271318-3148-3-git-send-email-jbarnes@virtuousgeek.org> <20121030175931.GA5755@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id CC1D09E7D1 for ; Tue, 30 Oct 2012 14:33:03 -0700 (PDT) In-Reply-To: <20121030175931.GA5755@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 30 Oct 2012 18:59:31 +0100, Daniel Vetter wrote: > On Fri, Oct 26, 2012 at 10:08:38AM -0700, Jesse Barnes wrote: > > The BIOS shouldn't be touching this memory across suspend/resume, so > > just leave it alone. This saves us ~50ms on resume on my T420. > > > > v2: change gtt restore default on pre-gen4 (Chris) > > move needs_gtt_restore flag into dev_priv > > > > Signed-off-by: Jesse Barnes > > I've just realized: GGTT PTEs are stored in stolen mem, and hence not > restored accross S4. How to ruin the day. So we may as just evict everything upon suspend and rebuild as needed? -Chris -- Chris Wilson, Intel Open Source Technology Centre