From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Implement workaround for broken
	CS tlb on i830/845
Date: Mon, 17 Dec 2012 13:33:01 +0000
Message-ID: <6c3329$7mbtk2@orsmga002.jf.intel.com>
References: <1355697960-8063-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 07D21E5C57
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 17 Dec 2012 05:33:15 -0800 (PST)
In-Reply-To: <1355697960-8063-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, 16 Dec 2012 22:46:00 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> @@ -1087,6 +1087,9 @@ i915_error_first_batchbuffer(struct drm_i915_private *dev_priv,
>  	if (!ring->get_seqno)
>  		return NULL;
>  
> +	if (HAS_BROKEN_CS_TLB(dev_priv->dev))
> +		return i915_error_object_create(dev_priv, ring->private);

Hmm, this is complicated by userspace opting out of the CS w/a, and
imposes quite a burden upon our simple seq interface.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre