From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/2] drm/i915: Reclaim GGTT space for failed
	ppgtt
Date: Fri, 28 Dec 2012 11:56:37 +0000
Message-ID: <6c3329$7rsshl@orsmga002.jf.intel.com>
References: <1356661642-1285-1-git-send-email-ben@bwidawsk.net>
	<1356661642-1285-2-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id B5FC4E5CCA
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 28 Dec 2012 03:56:55 -0800 (PST)
In-Reply-To: <1356661642-1285-2-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 27 Dec 2012 18:27:22 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> When the ppgtt init fails, we may as well reuse the space that were were
> reserving for the ppgtt PDEs.
> 
> This also fixes an extraneous mutex_unlock.

Hear, hear.

Could I ask for the int ret; to be killed off entirely?

[both] Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre