From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking
Date: Mon, 30 Sep 2024 08:45:26 +0200 [thread overview]
Message-ID: <6c3e6071-822f-4230-b76b-276330de07ef@kernel.org> (raw)
In-Reply-To: <CABGWkvqqg-PGAZTCz=MMLRx5F93jaN_=z8zJt1sDd3PHXd80PQ@mail.gmail.com>
On 29/09/2024 22:00, Dario Binacchi wrote:
>>
>>
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - fsl,imx8mm-anatop
>>> +
>>> +then:
>>> + properties:
>>> + fsl,ssc-clocks:
>>
>> Nope. Properties must be defined in top-level.
>>
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>> + description:
>>> + The phandles to the PLLs with spread spectrum clock generation
>>> + hardware capability.
>>
>> These should be clocks.
>
> Sorry, but I can't understand what you're asking me.
> Could you kindly explain it to me in more detail?
You added new property instead of using existing one for this purpose:
'clocks'.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-30 6:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 8:37 [PATCH 0/6] Support spread spectrum clocking for i.MX8{M,N,P} PLLs Dario Binacchi
2024-09-28 8:37 ` [PATCH 1/6] dt-bindings: clock: imx8m-anatop: support spread spectrum clocking Dario Binacchi
2024-09-28 12:09 ` Krzysztof Kozlowski
2024-09-29 20:00 ` Dario Binacchi
2024-09-30 6:45 ` Krzysztof Kozlowski [this message]
2024-10-01 6:29 ` Dario Binacchi
2024-10-03 10:46 ` Krzysztof Kozlowski
2024-10-05 8:57 ` Dario Binacchi
2024-10-06 13:13 ` Krzysztof Kozlowski
2024-10-07 15:02 ` Dario Binacchi
2024-10-08 8:20 ` Krzysztof Kozlowski
2024-10-08 9:16 ` Dario Binacchi
2024-10-23 14:58 ` Dario Binacchi
2024-10-23 17:49 ` Krzysztof Kozlowski
2024-10-28 10:32 ` Dario Binacchi
2024-09-28 8:37 ` [PATCH 2/6] clk: imx: pll14xx: support spread spectrum clock generation Dario Binacchi
2024-09-28 8:37 ` [PATCH 3/6] clk: imx8mm: " Dario Binacchi
2024-09-28 8:37 ` [PATCH 4/6] clk: imx8mn: " Dario Binacchi
2024-09-28 8:37 ` [PATCH 5/6] clk: imx8mp: don't lose the anatop device node Dario Binacchi
2024-09-28 8:37 ` [PATCH 6/6] clk: imx8mp: support spread spectrum clock generation Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c3e6071-822f-4230-b76b-276330de07ef@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.