From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B719EC001B2 for ; Wed, 14 Dec 2022 11:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238151AbiLNLFU convert rfc822-to-8bit (ORCPT ); Wed, 14 Dec 2022 06:05:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238142AbiLNLFT (ORCPT ); Wed, 14 Dec 2022 06:05:19 -0500 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51176E79 for ; Wed, 14 Dec 2022 03:05:16 -0800 (PST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-242-JdesrG8NMdGniNtm-PNc3Q-1; Wed, 14 Dec 2022 11:05:13 +0000 X-MC-Unique: JdesrG8NMdGniNtm-PNc3Q-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 14 Dec 2022 11:05:10 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.044; Wed, 14 Dec 2022 11:05:10 +0000 From: David Laight To: 'Nicolas Schier' , Nathan Chancellor CC: Masahiro Yamada , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Nick Desaulniers Subject: RE: [PATCH] kbuild: ensure Make >= 3.82 is used Thread-Topic: [PATCH] kbuild: ensure Make >= 3.82 is used Thread-Index: AQHZDqgK2HakTLHXy0uTd8KCKGQlc65tOHlQ Date: Wed, 14 Dec 2022 11:05:10 +0000 Message-ID: <6c4413040a624b728081e27213fb46a1@AcuMS.aculab.com> References: <20221211030352.2622425-1-masahiroy@kernel.org> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org From: Nicolas Schier > Sent: 13 December 2022 03:59 ... > > > diff --git a/Makefile b/Makefile > > > index 2dda1e9a717a..66dfc5751470 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -11,6 +11,11 @@ NAME = Hurr durr I'ma ninja sloth > > > # Comments in this file are targeted only to the developer, do not > > > # expect to learn how to build the kernel reading this file. > > > > > > +# Ensure Make >= 3.82 Wouldn't it be better to say either: # Ensure gmake supports 'undefine' (added in 3.82) or: # Building with gmake versions prior to 3.82 fails due to # bug 'brief description'. # Check for 'undefine' support as a surrogate for the bug fix. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)