From: Sibi Sankar <sibis@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
agross@kernel.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH -next] cpufreq: qcom-hw: remove set but not used variable 'prev_cc'
Date: Thu, 22 Aug 2019 10:25:11 +0530 [thread overview]
Message-ID: <6c485d00652f873b98664ff211e496cd@codeaurora.org> (raw)
In-Reply-To: <20190822024051.eubzzxh3b2ip2gzv@vireshk-i7>
@YueHaibing thanks for the patch.
On 2019-08-22 08:10, Viresh Kumar wrote:
> On 21-08-19, 20:14, YueHaibing wrote:
>> drivers/cpufreq/qcom-cpufreq-hw.c: In function
>> qcom_cpufreq_hw_read_lut:
>> drivers/cpufreq/qcom-cpufreq-hw.c:89:38: warning:
>> variable prev_cc set but not used [-Wunused-but-set-variable]
>>
>> It is not used since commit 3003e75a5045 ("cpufreq:
>> qcom-hw: Update logic to detect turbo frequency")
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/cpufreq/qcom-cpufreq-hw.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c
>> b/drivers/cpufreq/qcom-cpufreq-hw.c
>> index 3eea197..a9ae2f8 100644
>> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
>> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
>> @@ -86,7 +86,7 @@ static int qcom_cpufreq_hw_read_lut(struct device
>> *cpu_dev,
>> struct cpufreq_policy *policy,
>> void __iomem *base)
>> {
>> - u32 data, src, lval, i, core_count, prev_cc = 0, prev_freq = 0,
>> freq;
>> + u32 data, src, lval, i, core_count, prev_freq = 0, freq;
>> u32 volt;
>> struct cpufreq_frequency_table *table;
>>
>> @@ -139,7 +139,6 @@ static int qcom_cpufreq_hw_read_lut(struct device
>> *cpu_dev,
>> break;
>> }
>>
>> - prev_cc = core_count;
>> prev_freq = freq;
>> }
>
> @Sibi, you fine with this change ? I will merge it with the original
> patch then.
yes the changes seem fine, I missed
removing prev_cc.
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-08-22 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 12:14 [PATCH -next] cpufreq: qcom-hw: remove set but not used variable 'prev_cc' YueHaibing
2019-08-22 2:40 ` Viresh Kumar
2019-08-22 4:55 ` Sibi Sankar [this message]
2019-08-22 6:01 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c485d00652f873b98664ff211e496cd@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.