From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3544EE49A8 for ; Mon, 21 Aug 2023 09:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234516AbjHUJ7Z (ORCPT ); Mon, 21 Aug 2023 05:59:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234513AbjHUJ7Y (ORCPT ); Mon, 21 Aug 2023 05:59:24 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BD84D8 for ; Mon, 21 Aug 2023 02:59:22 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-522dd6b6438so3764318a12.0 for ; Mon, 21 Aug 2023 02:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692611960; x=1693216760; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NfnhEnLWB5KwPnq+5sUX4rq+xUeecsyqh2xi9cV8plo=; b=aegEo+5bPsOgM7Abn79QB6cXz2xQt9xi7cdVNNPmg9B7tT06PiGKgX1InoNGDl8bxZ 338mHckrPEE6CLB39U6vZu8e2dHjLZ3g1hSeEIFfzUmSZe/pLjll6pM/vOiOw7SPe9pV 6TKLHcwpfpFbDK7WYdfP/Oxj2UvZVX5fgihzmiBjduobni/IJL4C4m54oJJC0wj/zFXW IF6v01ixmdqh3LL3JnWCHdll3zJzuFo5dw2OP6JlZr7ja0tRF5q+vKed9x++YVwoYWe+ nF5lnXrdXUW7v51dx+9n9p0UXoxNBpNOm1ZMgs+eool586xi8FMx3BZLVcAWl+sEGi57 6aWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692611960; x=1693216760; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NfnhEnLWB5KwPnq+5sUX4rq+xUeecsyqh2xi9cV8plo=; b=ipM+1FwS8hV7vMgh6/Zc4zz2Xq5u2OR1BwkfoeBVhwwH6lT3Xc5ZiJhTVno0DoDrjP V/Tip20IHzSqBIJM0viLxceA+HuVEN43hEbB41l+1y4NGS5pWdRsMHh1KJgVpJYcbU97 CSmNRwIkoTTg2ZsBmX+gsIqlGspskW8I2wKtl4i5DQbMbp0TdJAvcjUQXpmyITop/Dts Ntdu2Qz6VmOTlec222tQmW+I17cEzW0+G1s3HhKBggWdTH6FWtv7NStRjibXKRWSjJ1/ CZUQHp/U4OGWs4FFw0iQNhEX++jRXmpUb7yGL/LltpKYeAqKQp8WtvNcqj12EbGeIfdM 7sUg== X-Gm-Message-State: AOJu0YxEUZejTL77sF0HjdiHW60LmA2n+o9cgCdWV6yTi+aGivXErpm/ 2YLV0NAk07cToK97Lt4euCGRGg== X-Google-Smtp-Source: AGHT+IG001d1cAQKIxx4riu0MNWkOswLnbQRQh6hkZ4rOg4g8XJRaQpDdMYLSRFQQO+P0HYNtp6SfA== X-Received: by 2002:aa7:d3d2:0:b0:521:a4bb:374f with SMTP id o18-20020aa7d3d2000000b00521a4bb374fmr4510485edr.5.1692611960545; Mon, 21 Aug 2023 02:59:20 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.107]) by smtp.gmail.com with ESMTPSA id y2-20020aa7d502000000b00529fb5fd3b9sm3996607edq.80.2023.08.21.02.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 02:59:20 -0700 (PDT) Message-ID: <6c76b28e-e995-2082-6dfa-378002989bcd@linaro.org> Date: Mon, 21 Aug 2023 10:59:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES Content-Language: en-US To: Nicolas Ferre , Varshini Rajendran , herbert@gondor.apana.org.au, davem@davemloft.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230728102442.265820-1-varshini.rajendran@microchip.com> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 8/21/23 09:59, Nicolas Ferre wrote: > On 28/07/2023 at 12:24, Varshini Rajendran wrote: >> Add DT bindings for atmel TDES. this commit message is way too succinct and hides the complexity that's needed in the driver >> >> Signed-off-by: Varshini Rajendran > > Following my answer to the email thread: > Acked-by: Nicolas Ferre > > Thanks, best regards, >   Nicolas > >> --- >>   .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml  | 6 +++++- >>   1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> index 3d6ed24b1b00..6a441f79efea 100644 >> --- >> a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> +++ >> b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml >> @@ -12,7 +12,11 @@ maintainers: >>     properties: >>     compatible: >> -    const: atmel,at91sam9g46-tdes >> +    oneOf: >> +      - const: atmel,at91sam9g46-tdes >> +      - items: >> +          - const: microchip,sam9x7-tdes >> +          - const: atmel,at91sam9g46-tdes why do you backup to "atmel,at91sam9g46-tdes"? Simply relying on "microchip,sam9x7-tdes" and its of_device_id data should be enough. >>       reg: >>       maxItems: 1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19CEEEE4993 for ; Mon, 21 Aug 2023 09:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dAG7fNyjb7NKMTqPwGhTY00dta5AJQUxCwt1Iuy9eFA=; b=Qxhl9o+CV1A3O5 4KEd1ZVPwF1Cyl+BqUK7mEhYbEjUPC1GPzWTWc7T8FIVPddJfOC8+6KAfvI2zgUycQ3gMIW//wGaE /uNLzYXptlG+jZtipG09eUebwMIIJt6oMNZPU6uiAVs5st3/AXo+eGQ16WsW4n1T4ZSwhAkOpAZQE hTlt392PQ+Wt4x/ZVpHh+/pEgSTmk08gG0OTZ4Cp8TMI7k0TO7uroimOyuJGkpXp/kP90Jma165aT Ei1CdLWk6bYlK7hJIgCLcHJbV9WjJn1ixnMJ2/UqI04relxRhoWnFNqqSYwMQ6byE9pLs0B/xTpcy OQUjsqAwxymYrt1oQhwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY1gz-00DcMZ-1Q; Mon, 21 Aug 2023 09:59:25 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY1gw-00DcLr-19 for linux-arm-kernel@lists.infradead.org; Mon, 21 Aug 2023 09:59:23 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-522dd6b6438so3764320a12.0 for ; Mon, 21 Aug 2023 02:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692611960; x=1693216760; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NfnhEnLWB5KwPnq+5sUX4rq+xUeecsyqh2xi9cV8plo=; b=aegEo+5bPsOgM7Abn79QB6cXz2xQt9xi7cdVNNPmg9B7tT06PiGKgX1InoNGDl8bxZ 338mHckrPEE6CLB39U6vZu8e2dHjLZ3g1hSeEIFfzUmSZe/pLjll6pM/vOiOw7SPe9pV 6TKLHcwpfpFbDK7WYdfP/Oxj2UvZVX5fgihzmiBjduobni/IJL4C4m54oJJC0wj/zFXW IF6v01ixmdqh3LL3JnWCHdll3zJzuFo5dw2OP6JlZr7ja0tRF5q+vKed9x++YVwoYWe+ nF5lnXrdXUW7v51dx+9n9p0UXoxNBpNOm1ZMgs+eool586xi8FMx3BZLVcAWl+sEGi57 6aWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692611960; x=1693216760; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NfnhEnLWB5KwPnq+5sUX4rq+xUeecsyqh2xi9cV8plo=; b=bnF4PnM2huD6T1Er01mu9JaRkUTDfny2ffEiKVWbdV+COcnxs4btevwx5OX+sfhmPv NhxrSoTkMc2Bq0unqkZCLCLxFljAmJbwWJtM3UH+0VvUOWVN6vEjMxmeFrbJ9xeDcRU7 I+vUBDHeLO5rCKqgJ7XFDRLkT+ouaBJdkvp/i4VwR/2Iwu467qvfSmuauwzIC/Gtj7N7 XVQeAR0t256hZllqzY8PRsjkjMirfu4QjldX7l2PY61cuR6P9cZq+dOxq7BhfogaYSHF dVf7/68/+LOmsynf+N089/97C1NMGdFvKdAly56FZJxk9dAQcmNwvT08nblYeaBSuY2j EPcA== X-Gm-Message-State: AOJu0Yy0k8NL2LAAzA80AJXcdu1V9/wTV/MreUnX0pbvLOF/Uh4OGoc+ IeqDO3/bWI2QYBimHbatKV/5qA== X-Google-Smtp-Source: AGHT+IG001d1cAQKIxx4riu0MNWkOswLnbQRQh6hkZ4rOg4g8XJRaQpDdMYLSRFQQO+P0HYNtp6SfA== X-Received: by 2002:aa7:d3d2:0:b0:521:a4bb:374f with SMTP id o18-20020aa7d3d2000000b00521a4bb374fmr4510485edr.5.1692611960545; Mon, 21 Aug 2023 02:59:20 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.107]) by smtp.gmail.com with ESMTPSA id y2-20020aa7d502000000b00529fb5fd3b9sm3996607edq.80.2023.08.21.02.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 02:59:20 -0700 (PDT) Message-ID: <6c76b28e-e995-2082-6dfa-378002989bcd@linaro.org> Date: Mon, 21 Aug 2023 10:59:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES Content-Language: en-US To: Nicolas Ferre , Varshini Rajendran , herbert@gondor.apana.org.au, davem@davemloft.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230728102442.265820-1-varshini.rajendran@microchip.com> From: Tudor Ambarus In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_025922_422938_9C214794 X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA4LzIxLzIzIDA5OjU5LCBOaWNvbGFzIEZlcnJlIHdyb3RlOgo+IE9uIDI4LzA3LzIwMjMg YXQgMTI6MjQsIFZhcnNoaW5pIFJhamVuZHJhbiB3cm90ZToKPj4gQWRkIERUIGJpbmRpbmdzIGZv ciBhdG1lbCBUREVTLgoKdGhpcyBjb21taXQgbWVzc2FnZSBpcyB3YXkgdG9vIHN1Y2NpbmN0IGFu ZCBoaWRlcyB0aGUgY29tcGxleGl0eSB0aGF0J3MKbmVlZGVkIGluIHRoZSBkcml2ZXIKCj4+Cj4+ IFNpZ25lZC1vZmYtYnk6IFZhcnNoaW5pIFJhamVuZHJhbiA8dmFyc2hpbmkucmFqZW5kcmFuQG1p Y3JvY2hpcC5jb20+Cj4gCj4gRm9sbG93aW5nIG15IGFuc3dlciB0byB0aGUgZW1haWwgdGhyZWFk Ogo+IEFja2VkLWJ5OiBOaWNvbGFzIEZlcnJlIDxuaWNvbGFzLmZlcnJlQG1pY3JvY2hpcC5jb20+ Cj4gCj4gVGhhbmtzLCBiZXN0IHJlZ2FyZHMsCj4gwqAgTmljb2xhcwo+IAo+PiAtLS0KPj4gwqAg Li4uL2RldmljZXRyZWUvYmluZGluZ3MvY3J5cHRvL2F0bWVsLGF0OTFzYW05ZzQ2LXRkZXMueWFt bMKgIHwgNiArKysrKy0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0Cj4+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2NyeXB0by9hdG1lbCxhdDkxc2FtOWc0Ni10ZGVzLnlhbWwKPj4gYi9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY3J5cHRvL2F0bWVsLGF0OTFzYW05ZzQ2LXRkZXMu eWFtbAo+PiBpbmRleCAzZDZlZDI0YjFiMDAuLjZhNDQxZjc5ZWZlYSAxMDA2NDQKPj4gLS0tCj4+ IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2NyeXB0by9hdG1lbCxhdDkxc2Ft OWc0Ni10ZGVzLnlhbWwKPj4gKysrCj4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2NyeXB0by9hdG1lbCxhdDkxc2FtOWc0Ni10ZGVzLnlhbWwKPj4gQEAgLTEyLDcgKzEyLDEx IEBAIG1haW50YWluZXJzOgo+PiDCoCDCoCBwcm9wZXJ0aWVzOgo+PiDCoMKgwqAgY29tcGF0aWJs ZToKPj4gLcKgwqDCoCBjb25zdDogYXRtZWwsYXQ5MXNhbTlnNDYtdGRlcwo+PiArwqDCoMKgIG9u ZU9mOgo+PiArwqDCoMKgwqDCoCAtIGNvbnN0OiBhdG1lbCxhdDkxc2FtOWc0Ni10ZGVzCj4+ICvC oMKgwqDCoMKgIC0gaXRlbXM6Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqAgLSBjb25zdDogbWljcm9j aGlwLHNhbTl4Ny10ZGVzCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqAgLSBjb25zdDogYXRtZWwsYXQ5 MXNhbTlnNDYtdGRlcwoKd2h5IGRvIHlvdSBiYWNrdXAgdG8gImF0bWVsLGF0OTFzYW05ZzQ2LXRk ZXMiPyBTaW1wbHkgcmVseWluZyBvbgoibWljcm9jaGlwLHNhbTl4Ny10ZGVzIiBhbmQgaXRzIG9m X2RldmljZV9pZCBkYXRhIHNob3VsZCBiZSBlbm91Z2guCgoKPj4gwqAgwqDCoMKgIHJlZzoKPj4g wqDCoMKgwqDCoCBtYXhJdGVtczogMQo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=