From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Lionel Landwerlin" <lionel.g.landwerlin@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add missing condition for committing planes on crtc
Date: Wed, 4 May 2016 12:30:50 +0200 [thread overview]
Message-ID: <6c8e5dde-e281-7ea2-2328-1c03d868dec5@linux.intel.com> (raw)
In-Reply-To: <fb022106-1431-7ef2-5370-ce0d254d8c56@intel.com>
Op 04-05-16 om 12:25 schreef Lionel Landwerlin:
> On 21/04/16 14:57, Ville Syrjälä wrote:
>> On Thu, Apr 21, 2016 at 03:30:09PM +0200, Maarten Lankhorst wrote:
>>> Hey,
>>>
>>> Op 18-04-16 om 13:05 schreef Lionel Landwerlin:
>>>> Ping?
>>>>
>>> Will commit, but looks like Ville made a comment about double buffering.
>>>
>>> Everything in intel_pipe_update_start depends on double buffering, so if the lut isn't then it probably has to be done either before or afterwards. Not sure which, either way would produce some flickering. :(
>> It should be done from a vblank worker. Unfortunately we still don't
>> have those, so either before or after is fine, and it'll result in
>> exactly the same amount of flickering as the current code.
>>
> Should I take from this that the patch is fine for now as we don't have vblank workers yet?
> I can resend another version with a TODO comment.
Ok, but make sure all CI tests pass this time. :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-04 13:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 16:30 [PATCH] drm/i915: add missing condition for committing planes on crtc Lionel Landwerlin
2016-04-09 6:26 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-04-21 13:34 ` Maarten Lankhorst
2016-04-18 11:05 ` [PATCH] " Lionel Landwerlin
2016-04-21 13:30 ` Maarten Lankhorst
2016-04-21 13:57 ` Ville Syrjälä
2016-05-04 10:25 ` Lionel Landwerlin
2016-05-04 10:30 ` Maarten Lankhorst [this message]
2016-05-04 11:41 ` Ville Syrjälä
2016-04-18 11:06 ` Maarten Lankhorst
2016-04-18 11:28 ` Ville Syrjälä
-- strict thread matches above, loose matches on Subject: below --
2016-05-04 11:13 Lionel Landwerlin
2016-05-09 7:37 ` Daniel Vetter
2016-05-04 13:40 Lionel Landwerlin
2016-05-04 14:30 ` Ville Syrjälä
2016-05-05 14:04 ` Lionel Landwerlin
2016-05-06 10:52 ` Ville Syrjälä
2016-05-09 7:41 ` Daniel Vetter
2016-05-09 14:40 Lionel Landwerlin
2016-05-11 10:51 ` Maarten Lankhorst
2016-05-12 10:31 ` Lionel Landwerlin
2016-05-17 7:28 ` Daniel Vetter
2016-05-25 13:20 Lionel Landwerlin
2016-05-25 13:30 Lionel Landwerlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8e5dde-e281-7ea2-2328-1c03d868dec5@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lionel.g.landwerlin@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.