Re: [PATCH v2] usb: dwc3: dwc3-am62: Re-initialize controller if lost power in PM suspend

[Roger Quadros <rogerq@kernel.org>]

On 11/12/2024 00:58, Thinh Nguyen wrote:
> On Mon, Dec 09, 2024, Roger Quadros wrote:
>> If controller looses power during PM suspend then re-initialize
>> it. We use the DEBUG_CFG register to track if controller lost power
>> or was reset in PM suspend.
>>
>> Move all initialization code into dwc3_ti_init() so it can be re-used.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> Changes in v2:
>> - fixed macro USBSS_DEBUG_CFG_OFF to 0
>> - Link to v1: https://urldefense.com/v3/__https://lore.kernel.org/r/20241122-am62-dwc3-io-ddr-v1-1-cc4956449420@kernel.org__;!!A4F2R9G_pg!fQlfE8tlmLW59YBhswZnfOSf_zypGRcqWV312B5A0NF0rLaOFPvTkWaPzCoKpz9E-2iihXpR87fFTrfubb-v$ 
>> ---
>>  drivers/usb/dwc3/dwc3-am62.c | 82 +++++++++++++++++++++++++++++---------------
>>  1 file changed, 55 insertions(+), 27 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
>> index 5e3d1741701f..7eef945b1f89 100644
>> --- a/drivers/usb/dwc3/dwc3-am62.c
>> +++ b/drivers/usb/dwc3/dwc3-am62.c
>> @@ -108,6 +108,9 @@
>>  
>>  #define DWC3_AM62_AUTOSUSPEND_DELAY	100
>>  
>> +#define USBSS_DEBUG_CFG_OFF		0x0
>> +#define USBSS_DEBUG_CFG_DISABLED	0x7
>> +
>>  struct dwc3_am62 {
>>  	struct device *dev;
>>  	void __iomem *usbss;
>> @@ -117,6 +120,7 @@ struct dwc3_am62 {
>>  	unsigned int offset;
>>  	unsigned int vbus_divider;
>>  	u32 wakeup_stat;
>> +	void __iomem *phy;
> 
> This is an odd way to name the iomem. I would associate "phy" to a
> device more than an iomem. How about phy_regs?
> 
> In any case, it's just minor nit. Regardless whether you want to rename
> it or not:

I agree with you that it is better to rename. I'll post a v3 soon.

> 
> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> 
> BR,
> Thinh

-- 
cheers,
-roger