From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 669CF1E9B1A; Wed, 25 Jun 2025 06:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750833733; cv=none; b=hu/FnL2o6856kOlDFxcCWI8XRr16HP8pF6uWvep9kTiqaIRW5dw/VLO2HhxcsJ9Isw2j5DqASVC8rSnHGmLB4Br6SPQ3gUQsN3mZaPv1Yq6Hryig3b0zaAB8b5wrTBP+cuboz+E/2fbHtrbNAsR9kdM5uCLLvNQyyJwXcAJy8Mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750833733; c=relaxed/simple; bh=CnoUkHx+3Zv32biwudTEAWRIP9eoJKj7s2aFPX8uKuM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p+lcn8dWEehw/FZO+qthxzdofHMIyL5BvHUOBy4OQvFdJKYIOPeq+S3zsP0eVl9Jin+8jHAll8UoRRcluRqcOUtGtCMtEocmLGRDUSa7L1KwuZEq4iiR83cs2C8xetFpVwHVv9+SNCwfuIIsXUWsV3pG86qyZHdo9bVmY9RBk6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QDsW9kHc; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QDsW9kHc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750833731; x=1782369731; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CnoUkHx+3Zv32biwudTEAWRIP9eoJKj7s2aFPX8uKuM=; b=QDsW9kHcTZuZpzcNnHwi4Tjstsw40yhNPQ289eYOigFeaNPYOwdDE7E4 ImpllmnrblXkzouF7Lkjoa8RjLZP8mJm6G8Iodwy6knkATH5g8CbdZZa+ +8rbkTWahdUi0Msfpst//U4j0DsGYls1hUucKk2f64LxBFN4sPGpF84cH tIuXtMzqh0ukl47OQCPy+bwm70ORR6BloSrxze4I4FhWqrxnt5mGUbWRf d/CeP4+NLT7m3LKvndt8ZgfG/3X+xoS8FdqGF5tmTA2DYKqqQP0OuGf68 wPg+pod9rmj0Xxjof8/uLDls10js3fJigSVRyafAF8lyNhYt6+w9ag2lC A==; X-CSE-ConnectionGUID: Xx7ihMFYQP6pL4FHkczxwA== X-CSE-MsgGUID: 9jY78WJJSZyEpYMrT8Fi3w== X-IronPort-AV: E=McAfee;i="6800,10657,11474"; a="55717863" X-IronPort-AV: E=Sophos;i="6.16,264,1744095600"; d="scan'208";a="55717863" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2025 23:42:11 -0700 X-CSE-ConnectionGUID: kTIZYBRtRq+v9oPu0ti44w== X-CSE-MsgGUID: buLOqMPCQAONl2o7vLQIgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,264,1744095600"; d="scan'208";a="183013642" Received: from xpardee-mobl.amr.corp.intel.com (HELO [10.246.154.149]) ([10.246.154.149]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2025 23:42:10 -0700 Message-ID: <6cceff87-56bc-4a7c-bbb9-caee2374e3ae@linux.intel.com> Date: Tue, 24 Jun 2025 23:42:09 -0700 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers To: Dan Carpenter , oe-kbuild@lists.linux.dev Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev References: Content-Language: en-US From: Xi Pardee In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Dan, Thanks for your comments. Responses are in line. Xi On 6/24/2025 7:45 AM, Dan Carpenter wrote: > Hi Xi, > > kernel test robot noticed the following build warnings: > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Xi-Pardee/platform-x86-intel-pmc-Enable-SSRAM-support-for-Lunar-Lake/20250622-050804 > base: linus/master > patch link: https://lore.kernel.org/r/20250621210529.237964-5-xi.pardee%40linux.intel.com > patch subject: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers > config: i386-randconfig-141-20250623 (https://download.01.org/0day-ci/archive/20250624/202506241840.0POVt4tf-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202506241840.0POVt4tf-lkp@intel.com/ > > New smatch warnings: > drivers/platform/x86/intel/pmc/core.c:1525 pmc_core_pmt_get_blk_sub_req() error: uninitialized symbol 'ret'. > drivers/platform/x86/intel/pmc/core.c:1559 pmc_core_get_telem_info() error: uninitialized symbol 'ret'. > > vim +/ret +1525 drivers/platform/x86/intel/pmc/core.c > > f3435ca196060d Xi Pardee 2025-06-21 1497 static int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc, > f3435ca196060d Xi Pardee 2025-06-21 1498 struct telem_endpoint *ep) > f3435ca196060d Xi Pardee 2025-06-21 1499 { > f3435ca196060d Xi Pardee 2025-06-21 1500 u32 num_blocker, sample_id; > f3435ca196060d Xi Pardee 2025-06-21 1501 unsigned int index; > f3435ca196060d Xi Pardee 2025-06-21 1502 u32 *req_offset; > f3435ca196060d Xi Pardee 2025-06-21 1503 int ret; > f3435ca196060d Xi Pardee 2025-06-21 1504 > f3435ca196060d Xi Pardee 2025-06-21 1505 num_blocker = pmc->map->num_s0ix_blocker; > f3435ca196060d Xi Pardee 2025-06-21 1506 sample_id = pmc->map->blocker_req_offset; > f3435ca196060d Xi Pardee 2025-06-21 1507 > f3435ca196060d Xi Pardee 2025-06-21 1508 pmc->blk_sub_req_regs = devm_kzalloc(&pmcdev->pdev->dev, > f3435ca196060d Xi Pardee 2025-06-21 1509 num_blocker * sizeof(u32), > > Use devm_kcalloc() so we don't have to check if num_blocker can be > greater than UINT_MAX / 4 on 32bit systems. > > f3435ca196060d Xi Pardee 2025-06-21 1510 GFP_KERNEL); > f3435ca196060d Xi Pardee 2025-06-21 1511 if (!pmc->blk_sub_req_regs) > f3435ca196060d Xi Pardee 2025-06-21 1512 ret = -ENOMEM; > > s/ret = /return /. Otherwise it leads to a NULL pointer dereference. > > f3435ca196060d Xi Pardee 2025-06-21 1513 > f3435ca196060d Xi Pardee 2025-06-21 1514 req_offset = pmc->blk_sub_req_regs; > f3435ca196060d Xi Pardee 2025-06-21 1515 for (index = 0; index < num_blocker; index++) { > > smatch doesn't know if num_blocker can be zero. To avoid the warning, return 0 instead when function succeeds in version 2. > > f3435ca196060d Xi Pardee 2025-06-21 1516 ret = pmt_telem_read32(ep, sample_id, req_offset, 1); > f3435ca196060d Xi Pardee 2025-06-21 1517 if (ret) { > f3435ca196060d Xi Pardee 2025-06-21 1518 dev_err(&pmcdev->pdev->dev, > f3435ca196060d Xi Pardee 2025-06-21 1519 "couldn't read Low Power Mode requirements: %d\n", ret); > f3435ca196060d Xi Pardee 2025-06-21 1520 return ret; > f3435ca196060d Xi Pardee 2025-06-21 1521 } > f3435ca196060d Xi Pardee 2025-06-21 1522 sample_id++; > f3435ca196060d Xi Pardee 2025-06-21 1523 req_offset++; > f3435ca196060d Xi Pardee 2025-06-21 1524 } > f3435ca196060d Xi Pardee 2025-06-21 @1525 return ret; > f3435ca196060d Xi Pardee 2025-06-21 1526 } > f3435ca196060d Xi Pardee 2025-06-21 1527 > f3435ca196060d Xi Pardee 2025-06-21 1528 static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func, unsigned int telem_info) > 78a7491d5cba8b Xi Pardee 2025-04-09 1529 { > b5d46539626833 Xi Pardee 2025-04-25 1530 struct pci_dev *pcidev __free(pci_dev_put) = NULL; > d7bc7e19147769 Xi Pardee 2025-06-21 1531 struct telem_endpoint *ep; > 052fabddeaa70b Xi Pardee 2025-04-09 1532 unsigned int i; > d7bc7e19147769 Xi Pardee 2025-06-21 1533 u32 guid; > 052fabddeaa70b Xi Pardee 2025-04-09 1534 int ret; > 78a7491d5cba8b Xi Pardee 2025-04-09 1535 > b5d46539626833 Xi Pardee 2025-04-25 1536 pcidev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(20, func)); > b5d46539626833 Xi Pardee 2025-04-25 1537 if (!pcidev) > 78a7491d5cba8b Xi Pardee 2025-04-09 1538 return -ENODEV; > 78a7491d5cba8b Xi Pardee 2025-04-09 1539 > 78a7491d5cba8b Xi Pardee 2025-04-09 1540 for (i = 0; i < ARRAY_SIZE(pmcdev->pmcs); ++i) { > d7bc7e19147769 Xi Pardee 2025-06-21 1541 struct pmc *pmc; > d7bc7e19147769 Xi Pardee 2025-06-21 1542 > d7bc7e19147769 Xi Pardee 2025-06-21 1543 pmc = pmcdev->pmcs[i]; > d7bc7e19147769 Xi Pardee 2025-06-21 1544 if (!pmc) > 78a7491d5cba8b Xi Pardee 2025-04-09 1545 continue; > 78a7491d5cba8b Xi Pardee 2025-04-09 1546 > d7bc7e19147769 Xi Pardee 2025-06-21 1547 guid = pmc_core_find_guid(pmcdev->regmap_list, pmc->map); > d7bc7e19147769 Xi Pardee 2025-06-21 1548 if (!guid) > d7bc7e19147769 Xi Pardee 2025-06-21 1549 return -ENXIO; > d7bc7e19147769 Xi Pardee 2025-06-21 1550 > d7bc7e19147769 Xi Pardee 2025-06-21 1551 ep = pmt_telem_find_and_register_endpoint(pcidev, guid, 0); > d7bc7e19147769 Xi Pardee 2025-06-21 1552 if (IS_ERR(ep)) { > d7bc7e19147769 Xi Pardee 2025-06-21 1553 dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep); > d7bc7e19147769 Xi Pardee 2025-06-21 1554 return -EPROBE_DEFER; > d7bc7e19147769 Xi Pardee 2025-06-21 1555 } > d7bc7e19147769 Xi Pardee 2025-06-21 1556 > f3435ca196060d Xi Pardee 2025-06-21 1557 if (telem_info & SUB_REQ_LPM) > d7bc7e19147769 Xi Pardee 2025-06-21 1558 ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep); > > ret is uninitialized on else path. I generally encourage developers > to set CONFIG_INIT_STACK_ALL_PATTERN=y for their testing. Changed to only check ret value in the if condition in version 2. > 78a7491d5cba8b Xi Pardee 2025-04-09 @1559 if (ret) > f3435ca196060d Xi Pardee 2025-06-21 1560 goto unregister_ep; > f3435ca196060d Xi Pardee 2025-06-21 1561 > f3435ca196060d Xi Pardee 2025-06-21 1562 if (telem_info & SUB_REQ_BLK) > f3435ca196060d Xi Pardee 2025-06-21 1563 ret = pmc_core_pmt_get_blk_sub_req(pmcdev, pmc, ep); > f3435ca196060d Xi Pardee 2025-06-21 1564 if (ret) > f3435ca196060d Xi Pardee 2025-06-21 1565 goto unregister_ep; > f3435ca196060d Xi Pardee 2025-06-21 1566 > f3435ca196060d Xi Pardee 2025-06-21 1567 pmt_telem_unregister_endpoint(ep); > 78a7491d5cba8b Xi Pardee 2025-04-09 1568 } > 78a7491d5cba8b Xi Pardee 2025-04-09 1569 > 78a7491d5cba8b Xi Pardee 2025-04-09 1570 return 0; > f3435ca196060d Xi Pardee 2025-06-21 1571 > f3435ca196060d Xi Pardee 2025-06-21 1572 unregister_ep: > f3435ca196060d Xi Pardee 2025-06-21 1573 pmt_telem_unregister_endpoint(ep); > f3435ca196060d Xi Pardee 2025-06-21 1574 return ret; > 78a7491d5cba8b Xi Pardee 2025-04-09 1575 } >