From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: kernel@collabora.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
parkeryang <Parker.Yang@mediatek.com>
Subject: Re: [PATCH 4/6] ASoC: mediatek: mt8188: Support DMIC in AFE
Date: Wed, 19 Feb 2025 12:29:13 +0100 [thread overview]
Message-ID: <6cd2be03-a3e8-4bdc-b91e-51b3e1029782@collabora.com> (raw)
In-Reply-To: <20250218-genio700-dmic-v1-4-6bc653da60f7@collabora.com>
Il 18/02/25 21:52, Nícolas F. R. A. Prado ha scritto:
> From: parkeryang <Parker.Yang@mediatek.com>
>
> Add the AFE routes that connect the DMIC (I004-I011) to the UL9 frontend
> (O002-O009) and register the mt8188-dmic DAI driver during probe.
>
> Signed-off-by: parkeryang <Parker.Yang@mediatek.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> sound/soc/mediatek/mt8188/Makefile | 1 +
> sound/soc/mediatek/mt8188/mt8188-afe-common.h | 1 +
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 24 ++++++++++++++++++++++++
> 3 files changed, 26 insertions(+)
>
> diff --git a/sound/soc/mediatek/mt8188/Makefile b/sound/soc/mediatek/mt8188/Makefile
> index 1178bce45c50ba252672a32b3877732a5a76c610..b9f3e4ad7b07ba9e21c846706371c53269f894db 100644
> --- a/sound/soc/mediatek/mt8188/Makefile
> +++ b/sound/soc/mediatek/mt8188/Makefile
> @@ -6,6 +6,7 @@ snd-soc-mt8188-afe-y := \
> mt8188-afe-pcm.o \
> mt8188-audsys-clk.o \
> mt8188-dai-adda.o \
> + mt8188-dai-dmic.o \
> mt8188-dai-etdm.o \
> mt8188-dai-pcm.o
The Makefile addition doesn't belong to this commit. Please fix.
The rest looks good.
Cheers,
Angelo
next prev parent reply other threads:[~2025-02-19 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 20:52 [PATCH 0/6] Enable DMIC for Genio 700/510 EVK Nícolas F. R. A. Prado
2025-02-18 20:52 ` [PATCH 1/6] ASoC: mediatek: mt8188: Add audsys hires clocks Nícolas F. R. A. Prado
2025-02-19 11:29 ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 2/6] ASoC: mediatek: mt8188: Add reference for dmic clocks Nícolas F. R. A. Prado
2025-02-19 11:29 ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 3/6] ASoC: mediatek: mt8188: Add DMIC DAI driver Nícolas F. R. A. Prado
2025-02-19 11:29 ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 4/6] ASoC: mediatek: mt8188: Support DMIC in AFE Nícolas F. R. A. Prado
2025-02-19 11:29 ` AngeloGioacchino Del Regno [this message]
2025-02-19 13:40 ` Nícolas F. R. A. Prado
2025-02-19 13:43 ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 5/6] ASoC: mediatek: mt8188-mt6359: Add DMIC Nícolas F. R. A. Prado
2025-02-19 11:29 ` AngeloGioacchino Del Regno
2025-02-18 20:52 ` [PATCH 6/6] arm64: dts: mediatek: mt8390-genio-common: Add routes for DMIC Nícolas F. R. A. Prado
2025-02-19 4:29 ` Chen-Yu Tsai
2025-02-19 13:30 ` Nícolas F. R. A. Prado
2025-02-19 11:29 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cd2be03-a3e8-4bdc-b91e-51b3e1029782@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Parker.Yang@mediatek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.