Re: [PATCH i-g-t] tests/kms_display_modes: reduce exec. time for sim env

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jeevan,

On 04-09-2025 09:13 am, Jeevan B wrote:
> For simulation environment, we can reduce execution time
> by running test only with one combination.
>
> v2: Remove redundant simulation check by using flag
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_display_modes.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index c93195b3c..e95e334d2 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -180,6 +180,7 @@ static void run_extendedmode_basic(data_t *data,
>   
>   static void run_extendedmode_test(data_t *data) {
>   	enum pipe pipe1, pipe2;
> +	bool sim_flag = igt_run_in_simulation();
>   	igt_output_t *output1, *output2;
>   	igt_display_t *display = &data->display;
>   
> @@ -218,9 +219,11 @@ static void run_extendedmode_test(data_t *data) {
>   			 * For simulation env, no need to run
>   			 * test with each valid output on pipe.
>   			 */

Can you fix this comment?
/*
  * In simulation env, only run the test once with a
  * single valid pipe/output pair instead of all combos.
  */

Otherwise patch LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
> -			if (igt_run_in_simulation())
> +			if (sim_flag)
>   				break;
>   		}
> +		if (sim_flag)
> +			break;
>   	}
>   }
>