From: "Kumar, Udit" <u-kumar1@ti.com>
To: Karl Mehltretter <kmehltretter@gmail.com>,
Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH 2/2] soc: ti: k3-ringacc: Fix DMA ring initialization kernel-doc
Date: Tue, 22 Sep 2026 21:34:49 +0530 [thread overview]
Message-ID: <6cf8cc99-c2d2-43cf-bcaa-bd9cfc8679d3@ti.com> (raw)
In-Reply-To: <20260919163721.89044-2-kmehltretter@gmail.com>
On 9/19/2026 10:07 PM, Karl Mehltretter wrote:
> The heading for k3_ringacc_init_data repeats struct, so kernel-doc
> cannot match it to the declaration. Its three fields are also missing
> descriptions.
>
> Use the structure name and describe the firmware handle, device ID,
> and number of ring pairs used during DMA ring initialization.
>
> Fixes: d782298c6f6b ("soc: ti: k3-ringacc: add AM64 DMA rings support.")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> include/linux/soc/ti/k3-ringacc.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/ti/k3-ringacc.h b/include/linux/soc/ti/k3-ringacc.h
> index 2de6031b9424..37a333f9a10b 100644
> --- a/include/linux/soc/ti/k3-ringacc.h
> +++ b/include/linux/soc/ti/k3-ringacc.h
> @@ -254,7 +254,10 @@ u32 k3_ringacc_get_tisci_dev_id(struct k3_ring *ring);
> struct ti_sci_handle;
>
> /**
> - * struct struct k3_ringacc_init_data - Initialization data for DMA rings
> + * struct k3_ringacc_init_data - Initialization data for DMA rings
> + * @tisci: TI SCI firmware handle
> + * @tisci_dev_id: TI SCI device ID of the DMA controller
> + * @num_rings: Number of forward/completion ring pairs
Sorry from where you got above definition of num_rings
> */
> struct k3_ringacc_init_data {
> const struct ti_sci_handle *tisci;
next prev parent reply other threads:[~2026-09-22 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 16:37 [PATCH 1/2] soc: ti: k3-ringacc: Correct ring API kernel-doc Karl Mehltretter
2026-09-19 16:37 ` [PATCH 2/2] soc: ti: k3-ringacc: Fix DMA ring initialization kernel-doc Karl Mehltretter
2026-09-22 16:04 ` Kumar, Udit [this message]
2026-09-22 19:17 ` Karl Mehltretter
2026-09-23 3:37 ` Kumar, Udit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cf8cc99-c2d2-43cf-bcaa-bd9cfc8679d3@ti.com \
--to=u-kumar1@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=kmehltretter@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.