From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBC0DCCF9F8 for ; Thu, 30 Oct 2025 07:47:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25E8510E231; Thu, 30 Oct 2025 07:47:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="kXB8Izta"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1809E10E231 for ; Thu, 30 Oct 2025 07:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761810423; x=1793346423; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=UKNt0W197HDR0DGmIfG35jioeH1mMr2/e9/AFOQzpXc=; b=kXB8Izta6ILK+8YVPvw00ls7pajgo63b4fMVVdlnzQKeDrzYjtBEP5UT Nr9WyGDQYuVascsByN53VFcbSHeKxMORl3iO+azglpRDAXyZWg5vlauE3 CxrBmuUtJN1T4j/ECd6kFcPc/s3Jyni7blVxZgFz+x6qbRhWzRM0Un8Qf YuvQh5lY2+dG0YWG5zSNq1BAke9IdEek50TcD97XqNFEU4ZpgoaJ7qj2B 02EpLkTX6ChyirQay2M162LearyFqqpmIZFl0X0t2KeARhmQY7M2z6HAe 0xFhUhlVgwnHtC1H6zRzpFtwk38JQ4SMRccu1HYas2GHy6VNJvMGwVPh1 w==; X-CSE-ConnectionGUID: mdc8EOfWRLWHzkOKSr9w0g== X-CSE-MsgGUID: FjAJPIV1Q46XGrLShColGg== X-IronPort-AV: E=McAfee;i="6800,10657,11597"; a="63981938" X-IronPort-AV: E=Sophos;i="6.19,266,1754982000"; d="scan'208";a="63981938" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2025 00:47:02 -0700 X-CSE-ConnectionGUID: dQu9QeojRc6KH3+T90OVLQ== X-CSE-MsgGUID: kRXKb89DS4CdEYYJfXiF7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,266,1754982000"; d="scan'208";a="190219420" Received: from kwachows-mobl.ger.corp.intel.com (HELO [10.246.16.226]) ([10.246.16.226]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2025 00:46:59 -0700 Message-ID: <6cfbb32b-7866-4fcc-98a3-1ded4558d43f@linux.intel.com> Date: Thu, 30 Oct 2025 08:46:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] accel/ivpu: replace use of system_wq with system_percpu_wq From: Karol Wachowski To: Marco Crivellari , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko , Maciej Falkowski , Oded Gabbay References: <20251029165642.364488-1-marco.crivellari@suse.com> <20251029165642.364488-3-marco.crivellari@suse.com> Content-Language: en-US Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/29/2025 9:02 PM, Karol Wachowski wrote: > On 10/29/2025 5:56 PM, Marco Crivellari wrote: >> Currently if a user enqueue a work item using schedule_delayed_work() the >> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use >> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to >> schedule_work() that is using system_wq and queue_work(), that makes use >> again of WORK_CPU_UNBOUND. >> >> This lack of consistency cannot be addressed without refactoring the API. >> >> system_wq should be the per-cpu workqueue, yet in this name nothing makes >> that clear, so replace system_wq with system_percpu_wq. >> >> The old wq (system_wq) will be kept for a few release cycles. >> >> Suggested-by: Tejun Heo >> Signed-off-by: Marco Crivellari >> --- >> drivers/accel/ivpu/ivpu_hw_btrs.c | 2 +- >> drivers/accel/ivpu/ivpu_ipc.c | 2 +- >> drivers/accel/ivpu/ivpu_job.c | 2 +- >> drivers/accel/ivpu/ivpu_mmu.c | 2 +- >> drivers/accel/ivpu/ivpu_pm.c | 3 ++- >> 5 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.c b/drivers/accel/ivpu/ivpu_hw_btrs.c >> index afdb3b2aa72a..27a345f3befe 100644 >> --- a/drivers/accel/ivpu/ivpu_hw_btrs.c >> +++ b/drivers/accel/ivpu/ivpu_hw_btrs.c >> @@ -673,7 +673,7 @@ bool ivpu_hw_btrs_irq_handler_lnl(struct ivpu_device *vdev, int irq) >> >> if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, SURV_ERR, status)) { >> ivpu_dbg(vdev, IRQ, "Survivability IRQ\n"); >> - queue_work(system_wq, &vdev->irq_dct_work); >> + queue_work(system_percpu_wq, &vdev->irq_dct_work); >> } >> >> if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, FREQ_CHANGE, status)) { >> diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c >> index 5f00809d448a..1f13bf95b2b3 100644 >> --- a/drivers/accel/ivpu/ivpu_ipc.c >> +++ b/drivers/accel/ivpu/ivpu_ipc.c >> @@ -459,7 +459,7 @@ void ivpu_ipc_irq_handler(struct ivpu_device *vdev) >> } >> } >> >> - queue_work(system_wq, &vdev->irq_ipc_work); >> + queue_work(system_percpu_wq, &vdev->irq_ipc_work); >> } >> >> void ivpu_ipc_irq_work_fn(struct work_struct *work) >> diff --git a/drivers/accel/ivpu/ivpu_job.c b/drivers/accel/ivpu/ivpu_job.c >> index 060f1fc031d3..7a1f78b84b09 100644 >> --- a/drivers/accel/ivpu/ivpu_job.c >> +++ b/drivers/accel/ivpu/ivpu_job.c >> @@ -574,7 +574,7 @@ static int ivpu_job_signal_and_destroy(struct ivpu_device *vdev, u32 job_id, u32 >> * status and ensure both are handled in the same way >> */ >> job->file_priv->has_mmu_faults = true; >> - queue_work(system_wq, &vdev->context_abort_work); >> + queue_work(system_percpu_wq, &vdev->context_abort_work); >> return 0; >> } >> >> diff --git a/drivers/accel/ivpu/ivpu_mmu.c b/drivers/accel/ivpu/ivpu_mmu.c >> index 5ea010568faa..e1baf6b64935 100644 >> --- a/drivers/accel/ivpu/ivpu_mmu.c >> +++ b/drivers/accel/ivpu/ivpu_mmu.c >> @@ -970,7 +970,7 @@ void ivpu_mmu_irq_evtq_handler(struct ivpu_device *vdev) >> } >> } >> >> - queue_work(system_wq, &vdev->context_abort_work); >> + queue_work(system_percpu_wq, &vdev->context_abort_work); >> } >> >> void ivpu_mmu_evtq_dump(struct ivpu_device *vdev) >> diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c >> index ffa2ba7cafe2..9ecba05ce7db 100644 >> --- a/drivers/accel/ivpu/ivpu_pm.c >> +++ b/drivers/accel/ivpu/ivpu_pm.c >> @@ -226,7 +226,8 @@ void ivpu_start_job_timeout_detection(struct ivpu_device *vdev) >> unsigned long timeout_ms = ivpu_tdr_timeout_ms ? ivpu_tdr_timeout_ms : vdev->timeout.tdr; >> >> /* No-op if already queued */ >> - queue_delayed_work(system_wq, &vdev->pm->job_timeout_work, msecs_to_jiffies(timeout_ms)); >> + queue_delayed_work(system_percpu_wq, &vdev->pm->job_timeout_work, >> + msecs_to_jiffies(timeout_ms)); >> } >> >> void ivpu_stop_job_timeout_detection(struct ivpu_device *vdev) > Reviewed-by: Karol Wachowski Pushed to drm-misc-next. -Karol