From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Alexander H Duyck <alexander.duyck@gmail.com>, netdev@vger.kernel.org
Cc: Matt Johnston <matt@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Harsh Tyagi <harshtya@google.com>
Subject: Re: [PATCH net] mctp: serial: Fix starting value for frame check sequence
Date: Sat, 17 Dec 2022 14:44:29 +0800 [thread overview]
Message-ID: <6d07e45e6237f24ec32a723e747dd070fb53bea7.camel@codeconstruct.com.au> (raw)
In-Reply-To: <2eecaca2d1066d51d136a8d95b5cd2fd19e5e111.camel@gmail.com>
Hi Alexander.
> Since the starting value isn't unique would it possibly be worthwhile
> to look at adding a define to include/linux/crc-ccitt.h to be used to
> handle the cases where the initial value is 0xffff? I notice there
> seems to only be two starting values 0 and 0xffff for all callers so
> it might make sense to centralize it in one place.
Yep, that would make sense if they're commonly used values, but I'm not
sure that would be suitable to include that in this fix, as it would
just add disruption to any backport work.
Cheers,
Jeremy
next prev parent reply other threads:[~2022-12-17 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 3:44 [PATCH net] mctp: serial: Fix starting value for frame check sequence Jeremy Kerr
2022-12-16 16:41 ` Alexander H Duyck
2022-12-17 6:44 ` Jeremy Kerr [this message]
2022-12-17 20:59 ` Alexander Duyck
2022-12-18 1:32 ` Jeremy Kerr
2022-12-19 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d07e45e6237f24ec32a723e747dd070fb53bea7.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harshtya@google.com \
--cc=kuba@kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.