From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>,
Joanne Koong <joannelkoong@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
shakeel.butt@linux.dev, athul.krishna.kr@protonmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v1 2/2] fs/writeback: skip inodes with potential writeback hang in wait_sb_inodes()
Date: Wed, 26 Nov 2025 11:41:58 +0100 [thread overview]
Message-ID: <6d0948f5-e739-49f3-8e23-359ddbf3da8f@kernel.org> (raw)
In-Reply-To: <CAJfpegvH=5bA3B=6Mkjs_X_RtXV+=bCnGCV7Oc_-rAy38-uZ1A@mail.gmail.com>
On 11/26/25 11:19, Miklos Szeredi wrote:
> On Tue, 25 Nov 2025 at 02:10, Joanne Koong <joannelkoong@gmail.com> wrote:
>
>> Prior to the changes added in commit 0c58a97f919c ("fuse: remove tmp
>> folio for writebacks and internal rb tree"), fuse didn't ensure that
>> data was written back for sync. The folio was marked as not under
>> writeback anymore, even if it was still under writeback.
>
> This is the main point. Fuse has existed for 20 years without data
> integrity guarantees. Reverting to that behavior is *not* a
> regression, it's simply a decades old bug. And solving that bug is
> darn hard, which is why it's not an option at this point.
Yes, and it should be clearly spelled out in the patch descriptions that
this is a fuse-only thing, and why it is a fuse-only thing. It's not a
"we don't have data integrity because writeback may hang", it's a "we
don't have data integrity because fuse never supported it, so waiting
here is simply not required".
--
Cheers
David
next prev parent reply other threads:[~2025-11-26 10:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 18:42 [PATCH v1 0/2] mm: skip wait in wait_sb_inodes() for hangable-writeback mappings Joanne Koong
2025-11-20 18:42 ` [PATCH v1 1/2] mm: rename AS_WRITEBACK_MAY_DEADLOCK_ON_RECLAIM to AS_WRITEBACK_MAY_HANG Joanne Koong
2025-11-20 20:08 ` David Hildenbrand (Red Hat)
2025-11-20 21:28 ` Joanne Koong
2025-11-20 18:42 ` [PATCH v1 2/2] fs/writeback: skip inodes with potential writeback hang in wait_sb_inodes() Joanne Koong
2025-11-20 18:44 ` kernel test robot
2025-11-20 18:51 ` Joanne Koong
2025-11-20 20:23 ` David Hildenbrand (Red Hat)
2025-11-20 21:20 ` Joanne Koong
2025-11-24 13:58 ` David Hildenbrand (Red Hat)
2025-11-25 1:10 ` Joanne Koong
2025-11-26 10:19 ` Miklos Szeredi
2025-11-26 10:41 ` David Hildenbrand (Red Hat) [this message]
2025-11-26 10:55 ` David Hildenbrand (Red Hat)
2025-11-26 17:58 ` Joanne Koong
2025-12-03 9:28 ` Miklos Szeredi
2025-12-04 18:06 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0948f5-e739-49f3-8e23-359ddbf3da8f@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=athul.krishna.kr@protonmail.com \
--cc=joannelkoong@gmail.com \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.