All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Enver Ikromov <owner@ph4ntom-rev.uz>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v5 08/10] wifi: rtw89: skip host-side TX hooks for injected frames
Date: Mon, 16 Nov 2026 02:20:40 +0000	[thread overview]
Message-ID: <6d14ce5428da43378c19fa56c1755c6e@realtek.com> (raw)
In-Reply-To: <20261113235211.1911-9-owner@ph4ntom-rev.uz>

Enver Ikromov <owner@ph4ntom-rev.uz> wrote:
> Several TX hooks assume frames that were built by the local network
> stack for an associated link:
> 
> - rtw89_traffic_stats_accu() and rtw89_core_tx_btc_spec_pkt_notify()
>   inspect ip_hdr()/udp_hdr(). For frames injected on a monitor
>   interface the network header points into the 802.11 header, so
>   traffic statistics and BT-coexistence notifications are derived
>   from unrelated bytes.
> - rtw89_wow_parse_akm() records the AKM from (Re)Association Request
>   frames for WoWLAN, which an injected frame must not change.
> - rtw89_core_tx_update_he_qos_htc(), rtw89_core_tx_update_ampdu_info(),
>   and rtw89_core_txq_check_agg() mutate QoS/HTC headers, enable A-MPDU
>   aggregation, or start/stop BA sessions based on link state, while
>   injected frames are expected to be sent as supplied.

If these are harmless to inject in single one monitor interface.
I prefer not applying these changes. 



  reply	other threads:[~2026-11-16  2:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 23:52 [PATCH rtw-next v5 00/10] wifi: rtw89: monitor mode RX filter and raw frame injection fixes Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 01/10] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-15  3:23   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 02/10] wifi: rtw89: handle negative rate index for injected frames Enver Ikromov
2026-11-15  3:38   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 03/10] wifi: rtw89: fix RX filter configuration for monitor mode Enver Ikromov
2026-11-15  3:48   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-17  7:17       ` Ping-Ke Shih
2026-11-17  9:40         ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 04/10] wifi: rtw89: protect pure_monitor_mode_vif with RCU Enver Ikromov
2026-11-15  4:00   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 05/10] wifi: rtw89: use AP self role for monitor interfaces Enver Ikromov
2026-11-15  4:08   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-17  0:41       ` Ping-Ke Shih
2026-11-17  9:40         ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 06/10] wifi: rtw89: transmit frames from " Enver Ikromov
2026-11-16  1:35   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 07/10] wifi: rtw89: send injected control frames through the management path Enver Ikromov
2026-11-16  2:14   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 08/10] wifi: rtw89: skip host-side TX hooks for injected frames Enver Ikromov
2026-11-16  2:20   ` Ping-Ke Shih [this message]
2026-11-16 15:28     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 09/10] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK " Enver Ikromov
2026-11-16  3:00   ` Ping-Ke Shih
2026-11-16 15:28     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 10/10] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-16  3:45   ` Ping-Ke Shih
2026-11-16 15:28     ` Enver Ikromov
2026-11-17  4:14       ` Zong-Zhe Yang
2026-11-17  9:40         ` Enver Ikromov
2026-11-16  7:56   ` Zong-Zhe Yang
2026-11-16 15:28     ` Enver Ikromov
2026-11-15  3:12 ` [PATCH rtw-next v5 00/10] wifi: rtw89: monitor mode RX filter and raw frame injection fixes Ping-Ke Shih
2026-11-16 15:27   ` Enver Ikromov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d14ce5428da43378c19fa56c1755c6e@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=owner@ph4ntom-rev.uz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.