Re: [PATCH v3] oeqa: Use --disable-maintainer-mode configure option

[Jacob Kroon <jacob.kroon@gmail.com>]

On 2/8/20 3:12 AM, Khem Raj wrote:
> since the versions of autotools might differ, and difference in
> timestamps for configure and system can result in reconfigure lets avoid
> that by touching the configure script to match system time
>

Maybe align commit message with patch, and mention 
--disable-maintainer-mode ?

Jacob

> Avoids
> error: newly created file is older than distributed files!
> 
> [YOCTO #13779]
> 
> Suggested-by: Andre McCurdy <armccurdy@gmail.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v2: Touch configure to match timestamps with system
>      Move the touch cmd to configure step itself
> v3: Use --disable-maintainer-mode
> 
>   meta/lib/oeqa/runtime/cases/buildcpio.py | 2 +-
>   meta/lib/oeqa/sdk/cases/buildcpio.py     | 2 +-
>   meta/lib/oeqa/selftest/cases/meta_ide.py | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/buildcpio.py b/meta/lib/oeqa/runtime/cases/buildcpio.py
> index 4bd72dd37e..d0f91668b2 100644
> --- a/meta/lib/oeqa/runtime/cases/buildcpio.py
> +++ b/meta/lib/oeqa/runtime/cases/buildcpio.py
> @@ -27,6 +27,6 @@ class BuildCpioTest(OERuntimeTestCase):
>       @OEHasPackage(['autoconf'])
>       def test_cpio(self):
>           self.project.download_archive()
> -        self.project.run_configure()
> +        self.project.run_configure('--disable-maintainer-mode','')
>           self.project.run_make()
>           self.project.run_install()
> diff --git a/meta/lib/oeqa/sdk/cases/buildcpio.py b/meta/lib/oeqa/sdk/cases/buildcpio.py
> index b0beafb38f..902e93f623 100644
> --- a/meta/lib/oeqa/sdk/cases/buildcpio.py
> +++ b/meta/lib/oeqa/sdk/cases/buildcpio.py
> @@ -28,7 +28,7 @@ class BuildCpioTest(OESDKTestCase):
>               self.assertTrue(os.path.isdir(dirs["source"]))
>               os.makedirs(dirs["build"])
>   
> -            self._run("cd {build} && {source}/configure $CONFIGURE_FLAGS".format(**dirs))
> +            self._run("cd {build} && {source}/configure --disable-maintainer-mode $CONFIGURE_FLAGS".format(**dirs))
>               self._run("cd {build} && make -j".format(**dirs))
>               self._run("cd {build} && make install DESTDIR={install}".format(**dirs))
>   
> diff --git a/meta/lib/oeqa/selftest/cases/meta_ide.py b/meta/lib/oeqa/selftest/cases/meta_ide.py
> index 809142559a..87cc2844a8 100644
> --- a/meta/lib/oeqa/selftest/cases/meta_ide.py
> +++ b/meta/lib/oeqa/selftest/cases/meta_ide.py
> @@ -43,7 +43,7 @@ class MetaIDE(OESelftestTestCase):
>                           "https://ftp.gnu.org/gnu/cpio/cpio-2.13.tar.gz",
>                           self.tmpdir_metaideQA, self.td['DATETIME'], dl_dir=dl_dir)
>           self.project.download_archive()
> -        self.assertEqual(self.project.run_configure(), 0,
> +        self.assertEqual(self.project.run_configure('--disable-maintainer-mode',''), 0,
>                           msg="Running configure failed")
>           self.assertEqual(self.project.run_make(), 0,
>                           msg="Running make failed")
>