From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
Kees Cook <keescook@chromium.org>,
cocci@inria.fr
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: [cocci] how to check a for "don't care" state of a variable?
Date: Sat, 8 Oct 2022 13:02:41 +0200 [thread overview]
Message-ID: <6d1e1044-c4fe-2d86-67ba-0fad33103a3c@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2210080942250.3287@hadrien>
> - x = e;
> ... when != x
> ? x = e';
>
> The ? will stop the match if the thing is found,
You suggested to delete an assignment statement by a single SmPL rule.
I would miss the replacement then for the assignment target in
a macro/function call parameter.
> but won't require the presence of that thing for the match to be successful.
Thus I propose to reconsider the transformation approach in more detail.
I would expect that it needs to be determined if the assignment target
would be used at other places within a code block before a code modification
can be applied by a subsequent SmPL rule.
Will the algorithm require any additional case distinctions accordingly?
Regards,
Markus
next prev parent reply other threads:[~2022-10-08 11:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 23:11 [cocci] how to check a for "don't care" state of a variable? Kees Cook
2022-10-08 3:09 ` Kees Cook
2022-10-08 7:43 ` Julia Lawall
2022-10-08 8:55 ` Markus Elfring
2022-10-08 9:00 ` Julia Lawall
2022-10-08 9:15 ` Markus Elfring
2022-10-08 11:02 ` Markus Elfring [this message]
2022-10-09 15:10 ` Kees Cook
2022-10-09 15:12 ` Julia Lawall
2022-10-09 15:56 ` Markus Elfring
2022-10-09 17:37 ` Kees Cook
2022-10-09 18:02 ` Julia Lawall
2022-10-09 18:16 ` Kees Cook
2022-10-09 18:19 ` Julia Lawall
2022-10-10 2:16 ` Jason A. Donenfeld
2022-10-10 19:12 ` [cocci] Reconsidering selected SmPL code Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1e1044-c4fe-2d86-67ba-0fad33103a3c@web.de \
--to=markus.elfring@web.de \
--cc=Jason@zx2c4.com \
--cc=cocci@inria.fr \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.