From: Alex Hung <alex.hung@amd.com>
To: "Kees Cook" <kees@kernel.org>, "Timur Kristóf" <timur.kristof@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, Ray.Wu@amd.com,
Harry.Wentland@amd.com, Wenjing.Liu@amd.com, Chris.Park@amd.com,
Yu.Wang4@amd.com
Subject: Re: [PATCH 1/4] drm/amd/display: Fix warning for analog stream encoders
Date: Tue, 18 Nov 2025 18:48:55 -0700 [thread overview]
Message-ID: <6d1e9dda-2209-4cbc-87d1-cdb38b382b7a@amd.com> (raw)
In-Reply-To: <202511171214.FAFD75DD0@keescook>
On 11/17/25 13:16, Kees Cook wrote:
> On Thu, Nov 13, 2025 at 05:33:45PM +0100, Timur Kristóf wrote:
>> Fixes the following warning that some users are reporting
>> with some kernel configurations:
>>
>> "positional initialization of field in 'struct' declared
>> with 'designated_init' attribute"
>
> Yes, seen with CONFIG_RANDSTRUCT=y
>
> Thanks for the fix!
>
>> Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
>
> Acked-by: Kees Cook <kees@kernel.org>
>
Thanks and this patch is now merged to amd-staging-drm-next, but I found
it causes *some* compiler to fail.
I'd like to test whether the below change is able to fix both issues.
-static const struct stream_encoder_funcs dce110_an_str_enc_funcs = {};
+static const struct stream_encoder_funcs dce110_an_str_enc_funcs = {
+ .dp_set_stream_attribute = NULL,
+};
However, I could not reproduce ""positional initialization of field in
'struct' declared 'designated_init' attribute" in my local setup, with
either gcc or clang and "CONFIG_RANDSTRUCT=y"
Can someone try the above changes for me? really appreciate it. I will
create a patch if it works.
Alex Hung
next prev parent reply other threads:[~2025-11-19 1:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 16:33 [PATCH 0/4] drm/amd/display: Follow-up patches to analog support Timur Kristóf
2025-11-13 16:33 ` [PATCH 1/4] drm/amd/display: Fix warning for analog stream encoders Timur Kristóf
2025-11-17 20:16 ` Kees Cook
2025-11-19 1:48 ` Alex Hung [this message]
2025-11-13 16:33 ` [PATCH 2/4] drm/amd/display: Cleanup uses of the analog flag Timur Kristóf
2025-11-13 16:33 ` [PATCH 3/4] drm/amd/display: Cleanup early return in construct_phy Timur Kristóf
2025-11-13 16:33 ` [PATCH 4/4] drm/amd/display: Move analog check to dce110_hwseq Timur Kristóf
2025-11-17 22:18 ` [PATCH 0/4] drm/amd/display: Follow-up patches to analog support Mario Limonciello
2025-11-18 10:10 ` timur.kristof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1e9dda-2209-4cbc-87d1-cdb38b382b7a@amd.com \
--to=alex.hung@amd.com \
--cc=Chris.Park@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Ray.Wu@amd.com \
--cc=Wenjing.Liu@amd.com \
--cc=Yu.Wang4@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=kees@kernel.org \
--cc=timur.kristof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.