From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Jared Rossi" <jrossi@linux.ibm.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH] hw/s390x: Restrict "loadparm" property to devices that can be used for booting
Date: Wed, 13 Nov 2024 12:53:17 +0100 [thread overview]
Message-ID: <6d223fe9-9dc7-49fb-a5b7-8835ff2b52c8@linaro.org> (raw)
In-Reply-To: <20241113114741.681096-1-thuth@redhat.com>
On 13/11/24 11:47, Thomas Huth wrote:
> Commit bb185de423 ("s390x: Add individual loadparm assignment to
> CCW device") added a "loadparm" property to all CCW devices. This
> was a little bit unfortunate, since this property is only useful
> for devices that can be used for booting, but certainly it is not
> useful for devices like virtio-gpu or virtio-tablet.
>
> Thus let's restrict the property to CCW devices that we can boot from
> (i.e. virtio-block, virtio-net and vfio-ccw devices).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/ccw-device.h | 5 +++++
> hw/s390x/ccw-device.c | 4 +---
> hw/s390x/virtio-ccw-blk.c | 1 +
> hw/s390x/virtio-ccw-net.c | 1 +
> hw/vfio/ccw.c | 1 +
> 5 files changed, 9 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-11-13 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:47 [PATCH] hw/s390x: Restrict "loadparm" property to devices that can be used for booting Thomas Huth
2024-11-13 11:53 ` Philippe Mathieu-Daudé [this message]
2024-11-13 14:49 ` Jared Rossi
2024-11-14 12:39 ` Thomas Huth
2024-11-14 16:45 ` Jared Rossi
2024-11-13 20:50 ` Jared Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d223fe9-9dc7-49fb-a5b7-8835ff2b52c8@linaro.org \
--to=philmd@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=jrossi@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.