All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	David Owens <daowens01@gmail.com>,
	Robert Nelson <robertcnelson@gmail.com>,
	Romain Naour <romain.naour@smile.fr>,
	Andrei Aldea <andrei@ti.com>, Judith Mendez <jm@ti.com>,
	<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE_PM for eMMC/SD
Date: Wed, 12 Mar 2025 15:25:55 +0200	[thread overview]
Message-ID: <6d33b6fb-94a2-4740-9247-b51f9bc9feab@intel.com> (raw)
In-Reply-To: <20250312121712.1168007-1-ulf.hansson@linaro.org>

On 12/03/25 14:17, Ulf Hansson wrote:
> We have received reports about cards can become corrupt related to the
> aggressive PM support. Let's make a partial revert of the change that
> enabled the feature.
> 
> Reported-by: David Owens <daowens01@gmail.com>
> Reported-by: Romain Naour <romain.naour@smile.fr>
> Reported-by: Robert Nelson <robertcnelson@gmail.com>
> Tested-by: Robert Nelson <robertcnelson@gmail.com>
> Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>


> ---
>  drivers/mmc/host/sdhci-omap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 54d795205fb4..26a9a8b5682a 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev)
>  	/* R1B responses is required to properly manage HW busy detection. */
>  	mmc->caps |= MMC_CAP_NEED_RSP_BUSY;
>  
> -	/* Allow card power off and runtime PM for eMMC/SD card devices */
> -	mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM;
> +	/*  Enable SDIO card power off. */
> +	mmc->caps |= MMC_CAP_POWER_OFF_CARD;
>  
>  	ret = sdhci_setup_host(host);
>  	if (ret)


  reply	other threads:[~2025-03-12 13:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 12:17 [PATCH] mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE_PM for eMMC/SD Ulf Hansson
2025-03-12 13:25 ` Adrian Hunter [this message]
2025-03-16 20:54 ` Robert Nelson
2025-03-17 10:51   ` Ulf Hansson
2025-03-19  3:59     ` Tony Lindgren
2025-03-19 11:40       ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d33b6fb-94a2-4740-9247-b51f9bc9feab@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=andrei@ti.com \
    --cc=daowens01@gmail.com \
    --cc=jm@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robertcnelson@gmail.com \
    --cc=romain.naour@smile.fr \
    --cc=stable@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.