All of lore.kernel.org
 help / color / mirror / Atom feed
From: Binbin Wu <binbin.wu@linux.intel.com>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: TDX: Remove always true ifdef
Date: Sun, 20 Sep 2026 09:12:15 +0800	[thread overview]
Message-ID: <6d3d2d97-82ed-4cb3-8a76-e8bcac57f6ea@linux.intel.com> (raw)
In-Reply-To: <b519578d-60fb-4248-88eb-05bb9474762f@suse.com>

On 9/18/2026 7:36 PM, Nikolay Borisov wrote:
> 
> 
> On 26.08.26 г. 13:03 ч., Nikolay Borisov wrote:
>> CONFIG_KVM_INTEL_TDX depends on KVM_TDX_HOST, which in turn depends on
>> CONFIG_X86_64. So it's guaranteed that any code under ifdef
>> CONFIG_KVM_INTEL_TDX is also running under CONFIG_X86_64 being true,
>> remove pointless ifdef guard.
>>
>> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>

Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>

> 
> Gentle ping.

BTW, I find the patch has been applied to kvm-x86 next branch already.

> 
> 
>> ---
>>   arch/x86/kvm/vmx/main.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
>> index f204a0fc0a57..e9cca303c855 100644
>> --- a/arch/x86/kvm/vmx/main.c
>> +++ b/arch/x86/kvm/vmx/main.c
>> @@ -799,7 +799,6 @@ static void vt_write_tsc_multiplier(struct kvm_vcpu *vcpu)
>>       vmx_write_tsc_multiplier(vcpu);
>>   }
>>   -#ifdef CONFIG_X86_64
>>   static int vt_set_hv_timer(struct kvm_vcpu *vcpu, u64 guest_deadline_tsc,
>>                     bool *expired)
>>   {
>> @@ -818,7 +817,6 @@ static void vt_cancel_hv_timer(struct kvm_vcpu *vcpu)
>>         vmx_cancel_hv_timer(vcpu);
>>   }
>> -#endif
>>     static void vt_setup_mce(struct kvm_vcpu *vcpu)
>>   {
> 


  reply	other threads:[~2026-09-20  1:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 10:03 [PATCH] KVM: TDX: Remove always true ifdef Nikolay Borisov
2026-09-18 11:36 ` Nikolay Borisov
2026-09-20  1:12   ` Binbin Wu [this message]
2026-09-21 14:05 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d3d2d97-82ed-4cb3-8a76-e8bcac57f6ea@linux.intel.com \
    --to=binbin.wu@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.