From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BB5C433E0 for ; Thu, 21 Jan 2021 14:07:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9D8C239A4 for ; Thu, 21 Jan 2021 14:07:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9D8C239A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/jzp53eeTIjW9L84u5aY9MQbIs6zEXLj7kxZYCe63Nk=; b=0gnbHNif/ym0Cfn1FGT6S0MSW pzxgKQgOFxVuhtVD/Inq6lXWMdvB4BZhuNGeMhQGzQHAKARCu2TtsxHnOURAQ/gWPaEs0jtscqowT 6RnakBnzeS23wInpdTugVQshzx0pjlNLfmyAfmUXbYV3aQxgvNO+1Lmn8NIe5pVaisp8a1Y/O5LJQ OYTqE/tlzi0GJxhtfDNffisjeiwQwkeoyAiIbb4tc7dU8eflIdd2j6P9l1BzNsLzAnLBHgMtQqGaG iF1ovJ0cTFWjXZQO3bNp68AAl+pNHau1A9MPdveMBPdbABcqLLSHOW3mpbRB9keMxHF/GZqJr6pci GDexpsjJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2aab-0004Cg-MV; Thu, 21 Jan 2021 14:05:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2aaZ-0004C8-0a for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 14:05:31 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9445B239A4; Thu, 21 Jan 2021 14:05:29 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l2aaV-009Cp4-H1; Thu, 21 Jan 2021 14:05:27 +0000 MIME-Version: 1.0 Date: Thu, 21 Jan 2021 14:05:27 +0000 From: Marc Zyngier To: Mark Rutland Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. In-Reply-To: <20210121133235.GG48431@C02TD0UTHF1T.local> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> <71e94b48857cbdd21c5d6bdadf148621@kernel.org> <20210121133235.GG48431@C02TD0UTHF1T.local> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <6d4d606cd832230c159b12874d32e220@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, mohamed.mediouni@caramail.com, arnd@kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, will@kernel.org, stan@corellium.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_090531_129676_9EFACB0E X-CRM114-Status: GOOD ( 21.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Mohamed Mediouni , Will Deacon , Linux ARM , Stan Skowronek Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMS0yMSAxMzozMiwgTWFyayBSdXRsYW5kIHdyb3RlOgo+IE9uIFRodSwgSmFuIDIx LCAyMDIxIGF0IDAxOjIyOjM3UE0gKzAwMDAsIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAy MS0wMS0yMSAxMjo1MCwgTW9oYW1lZCBNZWRpb3VuaSB3cm90ZToKPj4gPiA+IE9uIDIxIEphbiAy MDIxLCBhdCAxMzo0NCwgQXJuZCBCZXJnbWFubiA8YXJuZEBrZXJuZWwub3JnPiB3cm90ZToKPj4g PiA+Cj4+ID4gPiBPbiBXZWQsIEphbiAyMCwgMjAyMSBhdCAyOjI3IFBNIE1vaGFtZWQgTWVkaW91 bmkKPj4gCj4+IFsuLi5dCj4+IAo+PiA+ID4gPiArICAgICAgIGFpYy5mYXN0X2lwaSA9IG9mX3By b3BlcnR5X3JlYWRfYm9vbChub2RlLCAiZmFzdC1pcGkiKTsKPj4gPiA+Cj4+ID4gPiBXaGVyZSBp cyB0aGlzIHByb3BlcnR5IGRvY3VtZW50ZWQsIGFuZCB3aGF0IGRlY2lkZXMgd2hpY2ggb25lIHRv IHVzZT8KPj4gPiBJdOKAmXMgZ2V0dGluZyBkb2N1bWVudGVkIGluIHRoZSBuZXh0IHBhdGNoIHNl dC4KPj4gPgo+PiA+IFRoaXMgcHJvcGVydHkgaXMgdGhlcmUgdG8gZW5hYmxlIHN1cHBvcnQgZm9y IG9sZGVyIGlQaG9uZSBwcm9jZXNzb3JzCj4+ID4gbGF0ZXIgb24sIHNvbWUgb2Ygd2hpY2ggZG8g bm90IGhhdmUgZmFzdCBJUEkgc3VwcG9ydC4KPj4gPgo+PiA+IE9uIEFwcGxlIE0xLCBmYXN0LWlw aSBpcyBhbHdheXMgb24uCj4+IAo+PiBUaGVuIHBsZWFzZSBmb2N1cyBvbiBhIHNpbmdsZSBpbXBs ZW1lbnRhdGlvbi4gQWRkaXRpb25hbCBmZWF0dXJlcyBjYW4KPj4gYWx3YXlzIGJlIG1lcmdlZCBs YXRlciBvbmNlIHNvbWV0aGluZyBpcyB1cCBhbmQgcnVubmluZy4KPj4gCj4+IEFsc28sIHRoZXJl IHN5c3JlZ3MgY2FuIGJlIGRldGVjdGVkIGJ5IG1hdGNoaW5nIHRoZSBNSURSLCBzbyBJIGRvbid0 Cj4+IHRoaW5rIHdlIG5lZWQgYSBEVCBwcm9wZXJ0eSBmb3IgdGhhdC4KPiAKPiBHZW5lcmFsbHkg d2UgZG8gbm90IGRldGVjdCBJTVAtREVGIHN5c3JlZ3MgYmFzZWQgb24gTUlEUiBiZWNhdXNlIHRo ZXkKPiB3b24ndCBuZWNlc3NhcmlseSBiZSBleHBvc2VkIHRvIGEgVk0sIHNvIEkgc3VzcGVjdCB0 aGF0IHdlIGRvIG5lZWQgRFQKPiBwcm9wZXJ0aWVzIHRvIGRlc2NyaWJlIHRoYXQgSU1QLURFRiBz eXNyZWdzIGFyZSBhY2Nlc3NpYmxlLCBhbmQgc2hvdWxkCj4gbm90IHJlbHkgb24gdGhlIE1JRFIg YWxvbmUuIE1heWJlIHRoYXQncyBpbXBsaWNpdCBpbiBhbm90aGVyIHByb3BlcnR5LAo+IGJ1dCB3 b3J0aCBiZWFyaW5nIGluIG1pbmQuCgpIbW0uIFRoYXQncyBhIGdvb2QgcG9pbnQuIEkgdGhpbmsg dGhpcyBjb3VsZCBiZSBrZXllZCBvZmYKdGhlIGNvbXBhdGlibGUgcHJvcGVydHksIHdoaWNoIHNo b3VsZCBhY2N1cmF0ZWx5IHJlZmxlY3QKdGhlIHZlcnNpb24gb2YgdGhlIGludGVycnVwdCBjb250 cm9sbGVyLgoKVGhhbmtzLAoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1 c3Qgc21lbGxzIGZ1bm55Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDED8C433DB for ; Thu, 21 Jan 2021 14:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78DB3239A4 for ; Thu, 21 Jan 2021 14:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730616AbhAUOGc (ORCPT ); Thu, 21 Jan 2021 09:06:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:57508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728071AbhAUOGN (ORCPT ); Thu, 21 Jan 2021 09:06:13 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9445B239A4; Thu, 21 Jan 2021 14:05:29 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l2aaV-009Cp4-H1; Thu, 21 Jan 2021 14:05:27 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 21 Jan 2021 14:05:27 +0000 From: Marc Zyngier To: Mark Rutland Cc: Mohamed Mediouni , Arnd Bergmann , Linux ARM , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Will Deacon , Stan Skowronek Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. In-Reply-To: <20210121133235.GG48431@C02TD0UTHF1T.local> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> <71e94b48857cbdd21c5d6bdadf148621@kernel.org> <20210121133235.GG48431@C02TD0UTHF1T.local> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <6d4d606cd832230c159b12874d32e220@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, mohamed.mediouni@caramail.com, arnd@kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, will@kernel.org, stan@corellium.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-21 13:32, Mark Rutland wrote: > On Thu, Jan 21, 2021 at 01:22:37PM +0000, Marc Zyngier wrote: >> On 2021-01-21 12:50, Mohamed Mediouni wrote: >> > > On 21 Jan 2021, at 13:44, Arnd Bergmann wrote: >> > > >> > > On Wed, Jan 20, 2021 at 2:27 PM Mohamed Mediouni >> >> [...] >> >> > > > + aic.fast_ipi = of_property_read_bool(node, "fast-ipi"); >> > > >> > > Where is this property documented, and what decides which one to use? >> > It’s getting documented in the next patch set. >> > >> > This property is there to enable support for older iPhone processors >> > later on, some of which do not have fast IPI support. >> > >> > On Apple M1, fast-ipi is always on. >> >> Then please focus on a single implementation. Additional features can >> always be merged later once something is up and running. >> >> Also, there sysregs can be detected by matching the MIDR, so I don't >> think we need a DT property for that. > > Generally we do not detect IMP-DEF sysregs based on MIDR because they > won't necessarily be exposed to a VM, so I suspect that we do need DT > properties to describe that IMP-DEF sysregs are accessible, and should > not rely on the MIDR alone. Maybe that's implicit in another property, > but worth bearing in mind. Hmm. That's a good point. I think this could be keyed off the compatible property, which should accurately reflect the version of the interrupt controller. Thanks, M. -- Jazz is not dead. It just smells funny...