All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Sui Jingfeng <sui.jingfeng@linux.dev>, dri-devel@lists.freedesktop.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v5 1/2] drm/loongson: Introduce component framework support
Date: Mon, 29 Jul 2024 08:40:46 +0200	[thread overview]
Message-ID: <6dbe975a-59eb-4d4b-9fea-b930fa44e4ec@web.de> (raw)
In-Reply-To: <20240728152858.346211-2-sui.jingfeng@linux.dev>

…
> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
> @@ -0,0 +1,108 @@
…
> +#ifndef __LOONGSON_DRV_H__
> +#define __LOONGSON_DRV_H__
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

  parent reply	other threads:[~2024-07-29  6:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 15:28 [PATCH v5 0/2] drm/loongson: Introduce component framework support Sui Jingfeng
2024-07-28 15:28 ` [PATCH v5 1/2] " Sui Jingfeng
2024-07-29  6:15   ` Markus Elfring
2024-07-29  6:40   ` Markus Elfring [this message]
2024-07-30 17:46     ` Sui Jingfeng
2024-07-30 18:16       ` Markus Elfring
2024-07-29  7:37   ` Markus Elfring
2024-07-30 17:39     ` Sui Jingfeng
2024-08-03  3:59   ` kernel test robot
2024-07-28 15:28 ` [PATCH v5 2/2] drm/loongson: Add dummy gpu driver as a subcomponent Sui Jingfeng
2024-07-29  7:15   ` Markus Elfring
2024-07-30 17:57     ` Sui Jingfeng
2024-07-29  7:48   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dbe975a-59eb-4d4b-9fea-b930fa44e4ec@web.de \
    --to=markus.elfring@web.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=sui.jingfeng@linux.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.