Re: [PATCH 1/5] ALSA: hda: Drop device-argument in NHLT functions

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2021-10-18 2:01 PM, Takashi Iwai wrote:
> On Mon, 18 Oct 2021 11:07:15 +0200,
> Cezary Rojewski wrote:

...

>> Well, most invocations that end in error will cause stack of
>> error-logs (dev_xxx()) in the parent driver. NHLT reads:
>> Non-HDAudio-Link-Table. The name itself points reader towards
>> sound/hda already.
> 
> But then how dropping the device information would improve things at
> all?  It rather cuts off the link between that message and the later
> one.
> 
>> I understand that not everyone will google "NHLT"
>> and such but then there are ton of kernel messages which won't guide
>> reader by the hand anyway.
> 
> This can't be an excuse, we don't have to follow that anti pattern :)
> 
>> "NHLT table not found" is configuration problem, not a driver
>> problem. Mixing BIOS/config problems with driver ones leads to
>> incorrect conclusions what we want to avoid.
> 
> The configuration itself makes sense only if it's in actual use,
> i.e. the problem is always tied with the driver.
> 
> So, if any, you can put more information around the message mentioning
> that it's the configuration problem and what to do for users,
> e.g. check your BIOS, etc.  *That* would be the improvement.

Ok, I'll think about better solution. For now I'll just drop this patch 
from the series and send v2.

Thanks for the discussion!

Czarek