From: Felix Fietkau <nbd@nbd.name>
To: Valera Kozlov <valera.kozlov19@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: mt76: mt7996: use spin_lock_irqsave for reg_lock
Date: Wed, 16 Sep 2026 15:57:36 +0200 [thread overview]
Message-ID: <6dd72dec-0b37-43f9-b205-dc68bf5ce69b@nbd.name> (raw)
In-Reply-To: <20260901194338.110-1-valera.kozlov19@gmail.com>
On 01.09.26 21:43, Valera Kozlov wrote:
> mt7996_rr()/wr()/rmw() and mt7996_memcpy_fromio() take dev->reg_lock
> via spin_lock_bh() when accessing remapped registers. This is not
> safe against hard-IRQ context, which can lead to race conditions and
> kernel panics on some platforms.
What hard-IRQ context is accessing registers? I think it would be better
to fix that instead of imposing the irqsave cost on all register access.
> MediaTek's own vendor tree independently found and fixed this same
> issue, reporting it as causing AP panics via Asynchronous SError
> Interrupt during normal WiFi operation:
> https://github.com/mediatek/mtk-openwrt-feeds/commit/3edfc0cbf7dc666a0b051b54f51634d6ff2a3be6
I only get 404 on that link.
- Felix
prev parent reply other threads:[~2026-09-16 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 19:43 [PATCH v2 1/2] wifi: mt76: mt7996: use spin_lock_irqsave for reg_lock Valera Kozlov
2026-09-01 19:43 ` [PATCH v2 2/2] wifi: mt76: mt7996: route disassoc frames to ALTXQ Valera Kozlov
2026-09-04 17:25 ` Valera Kozlov
2026-09-16 13:57 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dd72dec-0b37-43f9-b205-dc68bf5ce69b@nbd.name \
--to=nbd@nbd.name \
--cc=linux-wireless@vger.kernel.org \
--cc=valera.kozlov19@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.