All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: Alain Volmat <alain.volmat@foss.st.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-media@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/13] media: stm32: dcmipp: add support for MP2x pixel pipes
Date: Mon, 27 Jul 2026 15:53:11 +0200	[thread overview]
Message-ID: <6decf51d-137c-4230-b823-64e61d76d0b8@kernel.org> (raw)
In-Reply-To: <20260724-stm32-dcmipp-pixel-pipes-support-v3-0-f77fe7e723d9@foss.st.com>

Hi Alain,

On 24/07/2026 18:13, Alain Volmat wrote:
> This series add support for the main & aux pixel pipes
> available on the MP2x. In addition to the byte pipe
> already available, the DCMIPP is able to process two
> other streams in parallel, including ISP operations
> such as demosaicing, exposure etc, post-processing operations
> such as cropping, downscaling and various pixel formats
> output.
> 
> This series introduces the whole DCMIPP pipelines including
> static configuration of the ISP part (such as demosaicing).
> Dynamic control of the ISP as well as statistic extraction
> part will be added on top of this serie via usage of 2 other
> video devices (input & output) for statistics extraction and
> dynamic ISP parameter injection.

Since this adds a new subdev, can you post the output of
'v4l2-compliance -s' for the MP2x?

Just to be certain all corner cases have been handled.

Regards,

	Hans

> 
> Changes in v3:
> - Rebased on top of kernel v7.2-rc4
> - Fixed most of Sashiko review points
> - Link to v2: https://lore.kernel.org/r/20260602-stm32-dcmipp-pixel-pipes-support-v2-0-3c76b5f93157@foss.st.com
> 
> Changes in v2:
> - Rebased on top of kernel v7.1-rc6
> - check-patch minor fixes
> - replaced kzalloc(.., sizeof(..),) with kzalloc_obj
> - Link to v1: https://lore.kernel.org/r/20260202-stm32-dcmipp-pixel-pipes-support-v1-0-8d8d51f5e014@foss.st.com
> 
> ---
> Alain Volmat (13):
>       media: stm32: dcmipp: share struct dcmipp_device among subdevs
>       media: stm32: dcmipp: make dcmipp_state & cmsr2 read common
>       media: stm32: dcmipp: bytecap: protect CMIER register access
>       media: stm32: dcmipp: move common structures in dcmipp-common.h
>       media: stm32: dcmipp: correct swap in YUYV data with parallel input
>       media: stm32: dcmipp: configure csi input of all pipes on stm32mp25
>       media: stm32: dcmipp: introduce a dcmipp global media_pipeline
>       media: stm32: dcmipp: add pixel pipes helper functions
>       media: stm32: dcmipp: addition of a dcmipp-isp subdev
>       media: stm32: dcmipp: pixelproc: addition of dcmipp-pixelproc subdev
>       media: stm32: dcmipp: add pixel-pipe support in bytecap
>       media: stm32: dcmipp: rename bytecap into capture
>       media: stm32: dcmipp: instantiate & link stm32mp25 subdevs
> 
>  .../media/platform/st/stm32/stm32-dcmipp/Makefile  |   3 +-
>  .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c        |  27 +-
>  .../{dcmipp-bytecap.c => dcmipp-capture.c}         | 600 +++++++++----
>  .../platform/st/stm32/stm32-dcmipp/dcmipp-common.h |  98 ++-
>  .../platform/st/stm32/stm32-dcmipp/dcmipp-core.c   | 124 ++-
>  .../platform/st/stm32/stm32-dcmipp/dcmipp-input.c  | 124 ++-
>  .../platform/st/stm32/stm32-dcmipp/dcmipp-isp.c    | 491 +++++++++++
>  .../st/stm32/stm32-dcmipp/dcmipp-pixelcommon.c     | 180 ++++
>  .../st/stm32/stm32-dcmipp/dcmipp-pixelcommon.h     |  41 +
>  .../st/stm32/stm32-dcmipp/dcmipp-pixelproc.c       | 941 +++++++++++++++++++++
>  10 files changed, 2344 insertions(+), 285 deletions(-)
> ---
> base-commit: 48a5a7ab8d6ab7090564339e039c421f315de912
> change-id: 20251219-stm32-dcmipp-pixel-pipes-support-b42924c0b4e5
> 
> Best regards,
> --  
> Alain Volmat <alain.volmat@foss.st.com>
> 
> 


  parent reply	other threads:[~2026-07-27 13:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 16:13 [PATCH v3 00/13] media: stm32: dcmipp: add support for MP2x pixel pipes Alain Volmat
2026-07-24 16:13 ` [PATCH v3 01/13] media: stm32: dcmipp: share struct dcmipp_device among subdevs Alain Volmat
2026-07-24 16:13 ` [PATCH v3 02/13] media: stm32: dcmipp: make dcmipp_state & cmsr2 read common Alain Volmat
2026-07-24 16:13 ` [PATCH v3 03/13] media: stm32: dcmipp: bytecap: protect CMIER register access Alain Volmat
2026-07-24 16:13 ` [PATCH v3 04/13] media: stm32: dcmipp: move common structures in dcmipp-common.h Alain Volmat
2026-07-24 16:13 ` [PATCH v3 05/13] media: stm32: dcmipp: correct swap in YUYV data with parallel input Alain Volmat
2026-07-24 16:13 ` [PATCH v3 06/13] media: stm32: dcmipp: configure csi input of all pipes on stm32mp25 Alain Volmat
2026-07-24 16:13 ` [PATCH v3 07/13] media: stm32: dcmipp: introduce a dcmipp global media_pipeline Alain Volmat
2026-07-24 16:13 ` [PATCH v3 08/13] media: stm32: dcmipp: add pixel pipes helper functions Alain Volmat
2026-07-24 16:13 ` [PATCH v3 09/13] media: stm32: dcmipp: addition of a dcmipp-isp subdev Alain Volmat
2026-07-24 16:13 ` [PATCH v3 10/13] media: stm32: dcmipp: pixelproc: addition of dcmipp-pixelproc subdev Alain Volmat
2026-07-27 13:49   ` Hans Verkuil
2026-08-20  7:13     ` Alain Volmat
2026-07-24 16:13 ` [PATCH v3 11/13] media: stm32: dcmipp: add pixel-pipe support in bytecap Alain Volmat
2026-07-24 16:13 ` [PATCH v3 12/13] media: stm32: dcmipp: rename bytecap into capture Alain Volmat
2026-07-24 16:13 ` [PATCH v3 13/13] media: stm32: dcmipp: instantiate & link stm32mp25 subdevs Alain Volmat
2026-07-27 13:53 ` Hans Verkuil [this message]
2026-08-20  7:14   ` [PATCH v3 00/13] media: stm32: dcmipp: add support for MP2x pixel pipes Alain Volmat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6decf51d-137c-4230-b823-64e61d76d0b8@kernel.org \
    --to=hverkuil+cisco@kernel.org \
    --cc=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=hugues.fruchet@foss.st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mchehab@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.