From: Chuck Lever <chuck.lever@oracle.com>
To: Daniel Gomez <da.gomez@kernel.org>, Luis Chamberlain <mcgrof@kernel.org>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH v3 01/10] playbooks: fix playbook name for all hosts plays
Date: Tue, 6 May 2025 16:39:38 -0400 [thread overview]
Message-ID: <6dedbabd-79b5-4350-8a11-287cc33de568@oracle.com> (raw)
In-Reply-To: <20250505-ansible_cfg_inventory-v3-1-a153d93c35c4@samsung.com>
On 5/5/25 5:24 PM, Daniel Gomez wrote:
> From: Daniel Gomez <da.gomez@samsung.com>
>
> Fix name rule by naming all the playbooks that run in all hosts.
>
> https://ansible.readthedocs.io/projects/lint/rules/name/
Nit: name[casing] states these names must begin with an upper case
letter. Ditto for 02/10.
Would be slightly nicer, perhaps, if these names were documentary
sentences, as they are in the roles themselves.
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
> ---
> playbooks/blktests.yml | 3 ++-
> playbooks/bootlinux.yml | 3 ++-
> playbooks/common.yml | 3 ++-
> playbooks/create_data_partition.yml | 3 ++-
> playbooks/cxl.yml | 3 ++-
> playbooks/devconfig.yml | 3 ++-
> playbooks/gitr.yml | 3 ++-
> playbooks/iscsi.yml | 3 ++-
> playbooks/kdc.yml | 3 ++-
> playbooks/krb5.yml | 3 ++-
> playbooks/ktls.yml | 3 ++-
> playbooks/ltp.yml | 3 ++-
> playbooks/nfsd.yml | 3 ++-
> playbooks/nfstest.yml | 3 ++-
> playbooks/pkg.yml | 3 ++-
> playbooks/pynfs.yml | 3 ++-
> playbooks/reboot-limit.yml | 3 ++-
> playbooks/rxe.yml | 3 ++-
> playbooks/selftests.yml | 3 ++-
> playbooks/siw.yml | 3 ++-
> playbooks/smbd.yml | 3 ++-
> playbooks/sysbench.yml | 3 ++-
> playbooks/terraform.yml | 3 ++-
> playbooks/update_etc_hosts.yml | 3 ++-
> 24 files changed, 48 insertions(+), 24 deletions(-)
>
> diff --git a/playbooks/blktests.yml b/playbooks/blktests.yml
> index 99732af2b681d5a8a161514513e564495a2686c9..91b484fbef5f8868b97fff337eaf5011e4c7f9f6 100644
> --- a/playbooks/blktests.yml
> +++ b/playbooks/blktests.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: blktests
> + hosts: all
> roles:
> - role: blktests
> diff --git a/playbooks/bootlinux.yml b/playbooks/bootlinux.yml
> index 418bbed4c060ed10333f2b1c5832f4217d18f458..676469d49348ad209bb2d094b86e088a4dcf03b0 100644
> --- a/playbooks/bootlinux.yml
> +++ b/playbooks/bootlinux.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: bootlinux
> + hosts: all
> roles:
> - role: bootlinux
> diff --git a/playbooks/common.yml b/playbooks/common.yml
> index 48485e3cfad5a253bd87ef231463167a824076f8..c4f0102b4bd5729d9ae347ae5c80a0a04576312e 100644
> --- a/playbooks/common.yml
> +++ b/playbooks/common.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: common
> + hosts: all
> roles:
> - role: common
> diff --git a/playbooks/create_data_partition.yml b/playbooks/create_data_partition.yml
> index fe7890b357c1ec0a4e42f29c24d2fbf093868fda..9cf4d0506c830847d54aa02555e0cc705b031cb3 100644
> --- a/playbooks/create_data_partition.yml
> +++ b/playbooks/create_data_partition.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: create_data_partition
> + hosts: all
> roles:
> - role: create_data_partition
> diff --git a/playbooks/cxl.yml b/playbooks/cxl.yml
> index 87638599bf4397c9508f7c746316e0f2e9312f67..65277d435a6fe13661febfea78181bf3a13e4dfc 100644
> --- a/playbooks/cxl.yml
> +++ b/playbooks/cxl.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: cxl
> + hosts: all
> roles:
> - role: cxl
> diff --git a/playbooks/devconfig.yml b/playbooks/devconfig.yml
> index 871651d740153d5ed0f75d466da5ca218362425e..45eb163bedd95c9cb8736f3cb68954df6dacf941 100644
> --- a/playbooks/devconfig.yml
> +++ b/playbooks/devconfig.yml
> @@ -1,5 +1,6 @@
> ---
> -- hosts: all
> +- name: devconfig
> + hosts: all
> gather_facts: no
> roles:
> - role: devconfig
> diff --git a/playbooks/gitr.yml b/playbooks/gitr.yml
> index 4c3e3ba919d767c897f79e30debd628737f89a82..5037a813f6b0a759bede52d7092af2bff218315b 100644
> --- a/playbooks/gitr.yml
> +++ b/playbooks/gitr.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: gitr
> + hosts: all
> roles:
> - role: gitr
> diff --git a/playbooks/iscsi.yml b/playbooks/iscsi.yml
> index cea400081c8dbc9558d88bebe649407f1b9b235e..5b3c4f356d8864761e5d768c81d740180a20740c 100644
> --- a/playbooks/iscsi.yml
> +++ b/playbooks/iscsi.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: iscsi
> + hosts: all
> roles:
> - role: iscsi
> diff --git a/playbooks/kdc.yml b/playbooks/kdc.yml
> index 66709db81d531e373f2e51770f1bee70b091d6f5..27de7faf436dd3061fbe20c22bac5f0131a21356 100644
> --- a/playbooks/kdc.yml
> +++ b/playbooks/kdc.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: kdc
> + hosts: all
> roles:
> - role: kdc
> diff --git a/playbooks/krb5.yml b/playbooks/krb5.yml
> index 52ca3ef5aef4ab08bd05f1c3fc8d01c7a653af32..8d65e560dab24b1a8f1457334c5a426dc40108c9 100644
> --- a/playbooks/krb5.yml
> +++ b/playbooks/krb5.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: krb5
> + hosts: all
> roles:
> - role: krb5
> diff --git a/playbooks/ktls.yml b/playbooks/ktls.yml
> index 8b7044c7ef2d26819333de2e0bd2f4dd6b00f688..70cc9c0c8fc3090083e4487298096252ebd5d7aa 100644
> --- a/playbooks/ktls.yml
> +++ b/playbooks/ktls.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: ktls
> + hosts: all
> roles:
> - role: ktls
> diff --git a/playbooks/ltp.yml b/playbooks/ltp.yml
> index 5921cefc76e4d4369e858709aeeb58878a101195..c01022f5f765b7e084c3806acd3d9ce249e445d6 100644
> --- a/playbooks/ltp.yml
> +++ b/playbooks/ltp.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: ltp
> + hosts: all
> roles:
> - role: ltp
> diff --git a/playbooks/nfsd.yml b/playbooks/nfsd.yml
> index 6c7735867eec9c570875dc02192e9494d811d364..edb8b1ff8de9eaf91cceedab7fe0a4672b1d7148 100644
> --- a/playbooks/nfsd.yml
> +++ b/playbooks/nfsd.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: nfsd
> + hosts: all
> roles:
> - role: nfsd
> diff --git a/playbooks/nfstest.yml b/playbooks/nfstest.yml
> index d414091aee7c24662a9e128d88da0b184697b9bf..03715ebf45f90070ba1d57feab27720f23d28d5e 100644
> --- a/playbooks/nfstest.yml
> +++ b/playbooks/nfstest.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: nfstest
> + hosts: all
> roles:
> - role: nfstest
> diff --git a/playbooks/pkg.yml b/playbooks/pkg.yml
> index f9d3e624551174e174d97e72776481b8a09d8505..60bee3cbd0382e2f2e0047fe1fadf245b685bc34 100644
> --- a/playbooks/pkg.yml
> +++ b/playbooks/pkg.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: pkg
> + hosts: all
> roles:
> - role: pkg
> diff --git a/playbooks/pynfs.yml b/playbooks/pynfs.yml
> index ad5b3e2b07328d2a63efb8e28694d38c9570950f..ea01b9af880476e3bbe74114f996885f7e922148 100644
> --- a/playbooks/pynfs.yml
> +++ b/playbooks/pynfs.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: pynfs
> + hosts: all
> roles:
> - role: pynfs
> diff --git a/playbooks/reboot-limit.yml b/playbooks/reboot-limit.yml
> index 37936237b5024700bb5fdf6e48cbf86120cc9900..160d6b9119788aed82e80740ecc2ab1edb208d89 100644
> --- a/playbooks/reboot-limit.yml
> +++ b/playbooks/reboot-limit.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: reboot-limit
> + hosts: all
> roles:
> - role: reboot-limit
> diff --git a/playbooks/rxe.yml b/playbooks/rxe.yml
> index dc51c0347628df781e4846bc72614300894a0a95..2204b10c136d5b2e0eb0e3262a9f2491fefdfce8 100644
> --- a/playbooks/rxe.yml
> +++ b/playbooks/rxe.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: rxe
> + hosts: all
> roles:
> - role: rxe
> diff --git a/playbooks/selftests.yml b/playbooks/selftests.yml
> index 6f7d7770816e2e34614fef4eee557fb615fafe14..2de584cb3c22ac08fa2d675ee5ef504671e8a389 100644
> --- a/playbooks/selftests.yml
> +++ b/playbooks/selftests.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: selftests
> + hosts: all
> roles:
> - role: selftests
> diff --git a/playbooks/siw.yml b/playbooks/siw.yml
> index 5258a5af9dca98873b0dbfb921169ea9de505f7c..cc546919681a15dff2a82472e1889711301b7a5c 100644
> --- a/playbooks/siw.yml
> +++ b/playbooks/siw.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: siw
> + hosts: all
> roles:
> - role: siw
> diff --git a/playbooks/smbd.yml b/playbooks/smbd.yml
> index 47cd0223164aa7970d2d20e520fb0468d03bc655..258edec6c5889b2a98a450d230b07a684b28568a 100644
> --- a/playbooks/smbd.yml
> +++ b/playbooks/smbd.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: smbd
> + hosts: all
> roles:
> - role: smbd
> diff --git a/playbooks/sysbench.yml b/playbooks/sysbench.yml
> index 61026356edc78a004fd01cd2f63a546bc13bc0d3..9cc043ba9d7a67f44d5b297dc8d0ea9cbe6b89ae 100644
> --- a/playbooks/sysbench.yml
> +++ b/playbooks/sysbench.yml
> @@ -1,4 +1,5 @@
> ---
> -- hosts: all
> +- name: sysbench
> + hosts: all
> roles:
> - role: sysbench
> diff --git a/playbooks/terraform.yml b/playbooks/terraform.yml
> index 374a76fb0ae73da8598bec53590e01b85a528053..1d212bd143ab49cc68b919022e8971d64c30270b 100644
> --- a/playbooks/terraform.yml
> +++ b/playbooks/terraform.yml
> @@ -1,5 +1,6 @@
> ---
> -- hosts: all
> +- name: terraform
> + hosts: all
> gather_facts: false
> roles:
> - role: terraform
> diff --git a/playbooks/update_etc_hosts.yml b/playbooks/update_etc_hosts.yml
> index a0c217411400a00cf6fccf00bb47860081ed9256..57d921ff627a6ffe798dfe90b49b769cd46fe62c 100644
> --- a/playbooks/update_etc_hosts.yml
> +++ b/playbooks/update_etc_hosts.yml
> @@ -1,5 +1,6 @@
> ---
> -- hosts: all
> +- name: update_etc_hosts
> + hosts: all
> gather_facts: no
> roles:
> - role: update_etc_hosts
>
--
Chuck Lever
next prev parent reply other threads:[~2025-05-06 20:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 21:24 [PATCH v3 00/10] Define Ansible inventory in the Ansible Configuration file Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 01/10] playbooks: fix playbook name for all hosts plays Daniel Gomez
2025-05-06 20:39 ` Chuck Lever [this message]
2025-05-07 12:04 ` Daniel Gomez
2025-05-07 14:02 ` Chuck Lever
2025-05-16 12:51 ` Daniel Gomez
2025-05-17 19:43 ` Chuck Lever
2025-05-17 20:34 ` Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 02/10] playbooks: fix playbook name for localhost plays Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 03/10] Makefile: use long form of limit argument for clarity Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 04/10] Makefile: print target when debug Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 05/10] .github/workflows/fstests.yml: enable make verbosity Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 06/10] ansible_cfg: add inventory support Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 07/10] gen_hosts: templates: include localhost in the all group Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 08/10] Makefile: use inventory from ansible.cfg Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 09/10] ansible_cfg: add support to change ansible.cfg file location Daniel Gomez
2025-05-05 21:24 ` [PATCH v3 10/10] docs: ansible_cfg: add documentation Daniel Gomez
2025-05-06 20:35 ` [PATCH v3 00/10] Define Ansible inventory in the Ansible Configuration file Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dedbabd-79b5-4350-8a11-287cc33de568@oracle.com \
--to=chuck.lever@oracle.com \
--cc=da.gomez@kernel.org \
--cc=da.gomez@samsung.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.