From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] nvme: handle completions outside of the queue lock
Date: Thu, 17 May 2018 09:33:34 -0600 [thread overview]
Message-ID: <6df24c77-bdc8-4265-30ea-8140eedc1fbd@kernel.dk> (raw)
In-Reply-To: <20180517153007.GB19042@infradead.org>
On 5/17/18 9:30 AM, Christoph Hellwig wrote:
> On Thu, May 17, 2018@08:22:01AM -0600, Jens Axboe wrote:
>> Just apply it on top, doesn't really warrant a rebase imho. But yeah,
>> we should probably cool the jets for a day next time :-)
>
> Honestly, between the poll issue and things like the volatile
> annotations that should have been a separate prep patch I'd rather
> back out and restart the thing slowly. We should still have plenty
> of time to get it done for this merge window.
The poll issue is almost moot imho, unless you have a ton of other
IO on the same hardware queue while you poll. It'll work fine, the
testing I ran didn't find anything. Agree the volatile should have
been a prep, but again not really a major thing.
--
Jens Axboe
next prev parent reply other threads:[~2018-05-17 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 3:23 [PATCH] nvme: handle completions outside of the queue lock Jens Axboe
2018-05-17 3:47 ` Keith Busch
2018-05-17 7:16 ` Christoph Hellwig
2018-05-17 7:47 ` Christoph Hellwig
2018-05-17 14:21 ` Jens Axboe
2018-05-17 15:03 ` Keith Busch
2018-05-17 15:29 ` Christoph Hellwig
2018-05-17 15:32 ` Keith Busch
2018-05-17 14:21 ` Keith Busch
2018-05-17 14:22 ` Jens Axboe
2018-05-17 15:30 ` Christoph Hellwig
2018-05-17 15:33 ` Jens Axboe [this message]
2018-05-17 15:35 ` Christoph Hellwig
2018-05-17 15:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6df24c77-bdc8-4265-30ea-8140eedc1fbd@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.