All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
	peter.ujfalusi@linux.intel.com, bard.liao@intel.com,
	linux-sound@vger.kernel.org, vkoul@kernel.org,
	broonie@kernel.org, tiwai@suse.de
Subject: Re: [PATCH 1/3] soundwire: allow drivers to check whether the peripheral is present
Date: Tue, 15 Sep 2026 20:31:52 +0200	[thread overview]
Message-ID: <6e00e449-6525-4200-bcac-ffb696204208@linux.dev> (raw)
In-Reply-To: <f1f14def-8b2f-4b55-89fd-65f1e35d48a8@intel.com>

On 9/15/26 19:32, Cezary Rojewski wrote:
> On 9/15/2026 3:13 PM, Bard Liao wrote:
>> A ghost peripheral may be listed in the ACPI table and we want to skip
>> it. Add enumeration_complete and is_present in struct sdw_bus{} allow
>> the driver to wait and check whether a peripheral is present.
>>
>> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>> ---
>>  drivers/soundwire/bus.c       | 7 +++++++
>>  include/linux/soundwire/sdw.h | 5 +++++
>>  2 files changed, 12 insertions(+)
>>
>> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
>> index aeaae5a57c89..b49864ca683a 100644
>> --- a/drivers/soundwire/bus.c
>> +++ b/drivers/soundwire/bus.c
>> @@ -161,7 +161,13 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,
>>  	bus->params.curr_dr_freq = bus->params.max_dr_freq;
>>  	bus->params.curr_bank = SDW_BANK0;
>>  	bus->params.next_bank = SDW_BANK1;
>> +	/*
>> +	 * Set is_present = true by default. It will be set to false when no peripherals
>> +	 * are attached on the bus.
>> +	 */
>> +	bus->is_present = true;
> 
> Does the approach permit existence of non-ghost, SDW master instance
> with no codecs attached?

Also wondering how the 'mockup' codecs would be handled? That's very
useful to test a manager with no actual codecs attached.
> 
>> +	init_completion(&bus->enumeration_complete);
>>  	return 0;
>>  }


  reply	other threads:[~2026-09-15 19:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 13:13 [PATCH 0/3] ASoC/soundwire: remove ghost peripherals from the mach table Bard Liao
2026-09-15 13:13 ` [PATCH 1/3] soundwire: allow drivers to check whether the peripheral is present Bard Liao
2026-09-15 17:32   ` Cezary Rojewski
2026-09-15 18:31     ` Pierre-Louis Bossart [this message]
2026-09-16  2:50       ` Liao, Bard
2026-09-15 13:13 ` [PATCH 2/3] soundwire: change sdw_show_ping_status type to int Bard Liao
2026-09-15 13:13 ` [PATCH 3/3] ASoC: SOF: Intel: wait and verifies the presence of SoundWire peripherals Bard Liao
2026-09-15 19:08 ` [PATCH 0/3] ASoC/soundwire: remove ghost peripherals from the mach table Pierre-Louis Bossart
2026-09-16  4:08   ` Liao, Bard
2026-10-07  2:25     ` Liao, Bard
2026-10-07 16:37       ` Pierre-Louis Bossart
2026-10-08  3:14         ` Liao, Bard
2026-10-08 17:09           ` Pierre-Louis Bossart
2026-10-12 14:46             ` Liao, Bard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e00e449-6525-4200-bcac-ffb696204208@linux.dev \
    --to=pierre-louis.bossart@linux.dev \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.