From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4] drm/i915: Flush the ring stop bit after clearing RING_HEAD in reset Date: Fri, 18 May 2018 12:05:17 +0100 Message-ID: <6e157f27-fcc6-ebe0-e549-c2f064f0c340@linux.intel.com> References: <20180518100933.2239-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EC456E11C for ; Fri, 18 May 2018 11:05:20 +0000 (UTC) In-Reply-To: <20180518100933.2239-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA1LzIwMTggMTE6MDksIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbnNpZGUgdGhlIGxp dmVfaGFuZ2NoZWNrIChyZXNldCkgc2VsZnRlc3RzLCB3ZSBvY2Nhc2lvbmFsbHkgc2VlCj4gZmFp bHVyZXMgbGlrZQo+IAo+IDw3PlsgIDIzOS4wOTQ4NDBdIGk5MTVfZ2VtX3NldF93ZWRnZWQgcmNz MAo+IDw3PlsgIDIzOS4wOTQ4NDNdIGk5MTVfZ2VtX3NldF93ZWRnZWQgCWN1cnJlbnQgc2Vxbm8g MTlhOTgsIGxhc3QgMTlhOWEsIGhhbmdjaGVjayAwIFs1MTU4IG1zXQo+IDw3PlsgIDIzOS4wOTQ4 NDZdIGk5MTVfZ2VtX3NldF93ZWRnZWQgCVJlc2V0IGNvdW50OiA2MjM5IChnbG9iYWwgMSkKPiA8 Nz5bICAyMzkuMDk0ODQ4XSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAlSZXF1ZXN0czoKPiA8Nz5bICAy MzkuMDk1MDUyXSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAkJZmlyc3QgIDE5YTk5IFtlOGM6NWZdIHBy aW89MTAyNCBAIDUxNTltczogKG51bGwpCj4gPDc+WyAgMjM5LjA5NTA1Nl0gaTkxNV9nZW1fc2V0 X3dlZGdlZCAJCWxhc3QgICAxOWE5YSBbZTgxOjFhXSBwcmlvPTEzOSBAIDUxNTltczogaWd0L3Jj czBbNTk3N10vMQo+IDw3PlsgIDIzOS4wOTUwNTldIGk5MTVfZ2VtX3NldF93ZWRnZWQgCQlhY3Rp dmUgMTlhOTkgW2U4Yzo1Zl0gcHJpbz0xMDI0IEAgNTE1OW1zOiAobnVsbCkKPiA8Nz5bICAyMzku MDk1MDYyXSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAkJW2hlYWQgMDIyMCwgcG9zdGZpeCAwMjgwLCB0 YWlsIDAyYTgsIGJhdGNoIDB4ZmZmZmZmZmZfZmZmZmZmZmZdCj4gPDc+WyAgMjM5LjEwMDA1MF0g aTkxNV9nZW1fc2V0X3dlZGdlZCAJCXJpbmctPnN0YXJ0OiAgMHgwMDI4MzAwMAo+IDw3PlsgIDIz OS4xMDAwNTNdIGk5MTVfZ2VtX3NldF93ZWRnZWQgCQlyaW5nLT5oZWFkOiAgIDB4MDAwMDAxZjgK PiA8Nz5bICAyMzkuMTAwMDU1XSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAkJcmluZy0+dGFpbDogICAw eDAwMDAwMmE4Cj4gPDc+WyAgMjM5LjEwMDA1N10gaTkxNV9nZW1fc2V0X3dlZGdlZCAJCXJpbmct PmVtaXQ6ICAgMHgwMDAwMDJhOAo+IDw3PlsgIDIzOS4xMDAwNTldIGk5MTVfZ2VtX3NldF93ZWRn ZWQgCQlyaW5nLT5zcGFjZTogIDB4MDAwMDBmMTAKPiA8Nz5bICAyMzkuMTAwMDg1XSBpOTE1X2dl bV9zZXRfd2VkZ2VkIAlSSU5HX1NUQVJUOiAweDAwMjgzMDAwCj4gPDc+WyAgMjM5LjEwMDA4OF0g aTkxNV9nZW1fc2V0X3dlZGdlZCAJUklOR19IRUFEOiAgMHgwMDAwMDI2MAo+IDw3PlsgIDIzOS4x MDAwOTFdIGk5MTVfZ2VtX3NldF93ZWRnZWQgCVJJTkdfVEFJTDogIDB4MDAwMDAyYTgKPiA8Nz5b ICAyMzkuMTAwMDk0XSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAlSSU5HX0NUTDogICAweDAwMDAwMDAx Cj4gPDc+WyAgMjM5LjEwMDA5N10gaTkxNV9nZW1fc2V0X3dlZGdlZCAJUklOR19NT0RFOiAgMHgw MDAwMDMwMCBbaWRsZV0KPiA8Nz5bICAyMzkuMTAwMTAwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAlS SU5HX0lNUjogZmZmZmZlZmUKPiA8Nz5bICAyMzkuMTAwMTA0XSBpOTE1X2dlbV9zZXRfd2VkZ2Vk IAlBQ1RIRDogIDB4MDAwMDAwMDBfMDAwMDYwOWMKPiA8Nz5bICAyMzkuMTAwMTA4XSBpOTE1X2dl bV9zZXRfd2VkZ2VkIAlCQkFERFI6IDB4MDAwMDAwMDBfMDAwMDYwOWQKPiA8Nz5bICAyMzkuMTAw MTExXSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAlETUFfRkFERFI6IDB4MDAwMDAwMDBfMDAyODMyNjAK PiA8Nz5bICAyMzkuMTAwMTE0XSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAlJUEVJUjogMHgwMDAwMDAw MAo+IDw3PlsgIDIzOS4xMDAxMTddIGk5MTVfZ2VtX3NldF93ZWRnZWQgCUlQRUhSOiAweDAyODAw MDAwCj4gPDc+WyAgMjM5LjEwMDEyMF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAJRXhlY2xpc3Qgc3Rh dHVzOiAweDAwMDQ0MDUyIDAwMDAwMDAyCj4gPDc+WyAgMjM5LjEwMDEyNF0gaTkxNV9nZW1fc2V0 X3dlZGdlZCAJRXhlY2xpc3QgQ1NCIHJlYWQgNSBbNSBjYWNoZWRdLCB3cml0ZSA1IFs1IGZyb20g aHdzXSwgaW50ZXJydXB0IHBvc3RlZD8gbm8sIHRhc2tsZXQgcXVldWVkPyBubyAoZW5hYmxlZCkK PiA8Nz5bICAyMzkuMTAwMTI4XSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAkJRUxTUFswXSBjb3VudD0x LCByaW5nLT5zdGFydD0wMDI4MzAwMCwgcnE6IDE5YTk5IFtlOGM6NWZdIHByaW89MTAyNCBAIDUx NjRtczogKG51bGwpCj4gPDc+WyAgMjM5LjEwMDEzMl0gaTkxNV9nZW1fc2V0X3dlZGdlZCAJCUVM U1BbMV0gY291bnQ9MSwgcmluZy0+c3RhcnQ9MDAyNTcwMDAsIHJxOiAxOWE5YSBbZTgxOjFhXSBw cmlvPTEzOSBAIDUxNjRtczogaWd0L3JjczBbNTk3N10vMQo+IDw3PlsgIDIzOS4xMDAxMzVdIGk5 MTVfZ2VtX3NldF93ZWRnZWQgCQlIVyBhY3RpdmU/IDB4NQo+IDw3PlsgIDIzOS4xMDAyNTBdIGk5 MTVfZ2VtX3NldF93ZWRnZWQgCQlFIDE5YTk5IFtlOGM6NWZdIHByaW89MTAyNCBAIDUxNjRtczog KG51bGwpCj4gPDc+WyAgMjM5LjEwMDMzOF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAJCUUgMTlhOWEg W2U4MToxYV0gcHJpbz0xMzkgQCA1MTY0bXM6IGlndC9yY3MwWzU5NzddLzEKPiA8Nz5bICAyMzku MTAwMzQwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkIAkJUXVldWUgcHJpb3JpdHk6IDEzOQo+IDw3Plsg IDIzOS4xMDAzNDNdIGk5MTVfZ2VtX3NldF93ZWRnZWQgCQlRIDAgW2U5ODoxOV0gcHJpbz0xMzIg QCA1MTY0bXM6IGlndC9yY3MwWzU5NzddLzgKPiA8Nz5bICAyMzkuMTAwMzQ2XSBpOTE1X2dlbV9z ZXRfd2VkZ2VkIAkJUSAwIFtlODQ6MTldIHByaW89MTIxIEAgNTE2NW1zOiBpZ3QvcmNzMFs1OTc3 XS8yCj4gPDc+WyAgMjM5LjEwMDM0OV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAJCVEgMCBbZTg3OjE5 XSBwcmlvPTgyIEAgNTE2NW1zOiBpZ3QvcmNzMFs1OTc3XS8zCj4gPDc+WyAgMjM5LjEwMDM1Ml0g aTkxNV9nZW1fc2V0X3dlZGdlZCAJCVEgMCBbZTg0OjFhXSBwcmlvPTQ0IEAgNTE2NG1zOiBpZ3Qv cmNzMFs1OTc3XS8yCj4gPDc+WyAgMjM5LjEwMDM1Nl0gaTkxNV9nZW1fc2V0X3dlZGdlZCAJCVEg MCBbZThiOjE5XSBwcmlvPTIwIEAgNTE2NW1zOiBpZ3QvcmNzMFs1OTc3XS80Cj4gPDc+WyAgMjM5 LjEwMDM2Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAJZHJ2X3NlbGZ0ZXN0IFs1ODk0XSB3YWl0aW5n IGZvciAxOWE5OQo+IAo+IHdoZXJlIHRoZSBHUFUgc2F3IGFuIGFyYml0cmF0aW9uIHBvaW50IGFu ZCBpZGxlczsgQU5EIEhBUyBOT1QgQkVFTiBSRVNFVCEKPiBUaGUgUklOR19NT0RFIGluZGljYXRl cyB0aGF0IGlzIGlkbGUgYW5kIGhhcyB0aGUgU1RPUF9SSU5HIGJpdCBzZXQsIHNvCj4gdHJ5IGNs ZWFyaW5nIGl0Lgo+IAo+IHYyOiBPbmx5IGNsZWFyIHRoZSBiaXQgb24gcmVzdGFydGluZyB0aGUg cmluZywgYXMgd2Ugd2FudCB0byBiZSBzdXJlIHRoZQo+IFNUT1BfUklORyBiaXQgaXMga2VwdCBp ZiByZXNldCBmYWlscyBvbiB3ZWRnaW5nLgo+IHYzOiBTcG90IHdoZW4gdGhlIHJpbmcgc3RhdGUg ZG9lc24ndCBtYWtlIHNlbnNlIHdoZW4gcmUtaW5pdGlhbGlzaW5nIHRoZQo+IGVuZ2luZSBhbmQg ZHVtcCBpdCB0byB0aGUgbG9ncyBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gd2FpdCBmb3IgYW4K PiBlcnJvciBsYXRlciBhbmQgdHJ5IHRvIGd1ZXNzIHdoYXQgaGFwcGVuZWQgZWFybGllci4KPiB2 NDogUHJlcGFyZSB0byBwcmludCBhbGwgdGhlIHVuZXhwZWN0ZWQgc3RhdGUsIG5vdCBqdXN0IHRo ZSBmaXJzdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4Lmlu dGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMjIg KysrKysrKysrKysrKysrKysrKysrKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMo KykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDM3NDRmNTc1MDYyNC4uYmE4 NDExYmE0YWJmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMTc4MSw2ICsx NzgxLDkgQEAgc3RhdGljIHZvaWQgZW5hYmxlX2V4ZWNsaXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUpCj4gICAJCUk5MTVfV1JJVEUoUklOR19NT0RFX0dFTjcoZW5naW5lKSwKPiAg IAkJCSAgIF9NQVNLRURfQklUX0VOQUJMRShHRlhfUlVOX0xJU1RfRU5BQkxFKSk7Cj4gICAKPiAr CUk5MTVfV1JJVEUoUklOR19NSV9NT0RFKGVuZ2luZS0+bW1pb19iYXNlKSwKPiArCQkgICBfTUFT S0VEX0JJVF9ESVNBQkxFKFNUT1BfUklORykpOwoKV29ycmllcyBtZSBhIGJpdCB0byBjbGVhciBp dCB1bmNvbmRpdGlvbmFsbHkgc2luY2UgZG9jdW1lbnRhdGlvbiBzYXlzIApub3RoaW5nICh0aGF0 IEkgY2FuIGZpbmQpIGFib3V0IHRoaXMgc2NlbmFyaW8uCgo+ICsKPiAgIAlJOTE1X1dSSVRFKFJJ TkdfSFdTX1BHQShlbmdpbmUtPm1taW9fYmFzZSksCj4gICAJCSAgIGVuZ2luZS0+c3RhdHVzX3Bh Z2UuZ2d0dF9vZmZzZXQpOwo+ICAgCVBPU1RJTkdfUkVBRChSSU5HX0hXU19QR0EoZW5naW5lLT5t bWlvX2Jhc2UpKTsKPiBAQCAtMTc4OSw2ICsxNzkyLDE5IEBAIHN0YXRpYyB2b2lkIGVuYWJsZV9l eGVjbGlzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWVuZ2luZS0+ZXhl Y2xpc3RzLmNzYl9oZWFkID0gLTE7Cj4gICB9Cj4gICAKPiArc3RhdGljIGJvb2wgdW5leHBlY3Rl ZF9zdGFydGluZ19zdGF0ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gK3sKPiAr CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2luZS0+aTkxNTsKPiArCWJv b2wgdW5leHBlY3RlZCA9IGZhbHNlOwo+ICsKPiArCWlmIChJOTE1X1JFQUQoUklOR19NSV9NT0RF KGVuZ2luZS0+bW1pb19iYXNlKSkgJiBTVE9QX1JJTkcpIHsKPiArCQlEUk1fREVCVUdfRFJJVkVS KCJTVE9QX1JJTkcgc3RpbGwgc2V0IGluIFJJTkdfTUlfTU9ERVxuIik7CgpBbHNvIHdvcnJpZXMg bWUgdG8gYnVyeSB0aGlzIGFzIGEgZGVidWcgbWVzc2FnZSB1bmxlc3Mgd2UgY2FuIGZpbmQgaW4g CmRvY3VtZW50YXRpb24gdGhhdCB0aGlzIGlzIGtub3duIHRvIGhhcHBlbiBvY2Nhc2lvbmFsbHku CgpJZiB3ZSBoYWQgdGhlIGNoZWNrIGFuZCBsb2dnaW5nIGltbWVkaWF0ZWx5IGFmdGVyIHJlc2V0 LCB3aXRoIGEgbW9yZSAKdmlzaWJsZSBsb2csIHdlIGNvdWxkIGJ1aWxkIGEgbGFyZ2VyIGRhdGEg c2V0IG9mIHJlcG9ydGVkIGZhaWx1cmVzIGFuZCAKdGhlbiBnbyBiYWNrIHRvIGh3IHBlb3BsZSBh bmQgYXNrIHRoZW0gYWJvdXQgaXQuCgo+ICsJCXVuZXhwZWN0ZWQgPSB0cnVlOwo+ICsJfQo+ICsK PiArCXJldHVybiB1bmV4cGVjdGVkOwo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCBnZW44X2luaXRf Y29tbW9uX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICAgCXN0 cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ ZXhlY2xpc3RzOwo+IEBAIC0xODAxLDYgKzE4MTcsMTIgQEAgc3RhdGljIGludCBnZW44X2luaXRf Y29tbW9uX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWludGVsX2Vu Z2luZV9yZXNldF9icmVhZGNydW1icyhlbmdpbmUpOwo+ICAgCWludGVsX2VuZ2luZV9pbml0X2hh bmdjaGVjayhlbmdpbmUpOwo+ICAgCj4gKwlpZiAoR0VNX1NIT1dfREVCVUcoKSAmJiB1bmV4cGVj dGVkX3N0YXJ0aW5nX3N0YXRlKGVuZ2luZSkpIHsKPiArCQlzdHJ1Y3QgZHJtX3ByaW50ZXIgcCA9 IGRybV9kZWJ1Z19wcmludGVyKF9fZnVuY19fKTsKPiArCj4gKwkJaW50ZWxfZW5naW5lX2R1bXAo ZW5naW5lLCAmcCwgTlVMTCk7Cj4gKwl9Cj4gKwo+ICAgCWVuYWJsZV9leGVjbGlzdHMoZW5naW5l KTsKPiAgIAo+ICAgCS8qIEFmdGVyIGEgR1BVIHJlc2V0LCB3ZSBtYXkgaGF2ZSByZXF1ZXN0cyB0 byByZXBsYXkgKi8KPiAKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==