From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
willemb@google.com, linux-kselftest@vger.kernel.org,
petrm@nvidia.com
Subject: Re: [PATCH net] selftests: drv-net: csum: fix interface name for remote host
Date: Sun, 31 Aug 2025 10:09:53 +0100 [thread overview]
Message-ID: <6e207b2b-b0ae-496c-b545-01e9844ffa15@linux.dev> (raw)
In-Reply-To: <20250830183842.688935-1-kuba@kernel.org>
On 30/08/2025 19:38, Jakub Kicinski wrote:
> Use cfg.remote_ifname for arguments of remote command.
> Without this UDP tests fail in NIPA where local interface
> is called enp1s0 and remote enp0s4.
>
> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: shuah@kernel.org
> CC: willemb@google.com
> CC: petrm@nvidia.com
> CC: linux-kselftest@vger.kernel.org
> ---
> tools/testing/selftests/drivers/net/hw/csum.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/drivers/net/hw/csum.py b/tools/testing/selftests/drivers/net/hw/csum.py
> index cd23af875317..3e3a89a34afe 100755
> --- a/tools/testing/selftests/drivers/net/hw/csum.py
> +++ b/tools/testing/selftests/drivers/net/hw/csum.py
> @@ -17,7 +17,7 @@ from lib.py import bkg, cmd, wait_port_listen
> ip_args = f"-{ipver} -S {cfg.remote_addr_v[ipver]} -D {cfg.addr_v[ipver]}"
>
> rx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -n 100 {ip_args} -r 1 -R {extra_args}"
> - tx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
> + tx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
>
> with bkg(rx_cmd, exit_wait=True):
> wait_port_listen(34000, proto="udp")
> @@ -37,7 +37,7 @@ from lib.py import bkg, cmd, wait_port_listen
> if extra_args != "-U -Z":
> extra_args += " -r 1"
>
> - rx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
> + rx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
> tx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -L 1 -n 100 {ip_args} -T {extra_args}"
>
> with bkg(rx_cmd, host=cfg.remote, exit_wait=True):
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2025-08-31 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 18:38 [PATCH net] selftests: drv-net: csum: fix interface name for remote host Jakub Kicinski
2025-08-30 19:58 ` Willem de Bruijn
2025-08-31 9:09 ` Vadim Fedorenko [this message]
2025-09-01 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e207b2b-b0ae-496c-b545-01e9844ffa15@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.