From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B2F0C433DB for ; Thu, 28 Jan 2021 09:03:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8EDA64DD1 for ; Thu, 28 Jan 2021 09:03:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8EDA64DD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d0tVJMwrQtO+qg5qGMYNrYv1MF6WB3gzzp8LU4C41TY=; b=l8KUmTpEySbNMsU7MYnQiEKcn ihVxgRcmT10KO7BrhtddRJMDOnnQ1ThValxpl734JEfTrdrcgj2VgsKprZlcmteKGoBmBNmq6iczS 0NK5wp4i7+QdzE7sP9W/EcBkCMhbn4nylLk0k77KHSqPSzQDCzK2PpRLWfwMubQY4MQQfbeZUUQJm IvTRhw1tMo0CZRBn+o1So6P5QfemCvYrIW7Yzpfdp0GD1GjjwiQX8GSH05vEPmQFdJHjZ2WFq2ueu FdEOvjOs3ORmuIRWHUtmNvjNJGvOwko6ML8Uw7DTgS6ooV0GTLQIy5LUzJDZiDXmddB5+K8SFJ8RV KoXxNyOOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l53Bz-0006lW-Ev; Thu, 28 Jan 2021 09:02:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l53Bx-0006l3-Cb for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 09:02:18 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BF1664DD6; Thu, 28 Jan 2021 09:02:16 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l53Bu-00AZWy-Bo; Thu, 28 Jan 2021 09:02:14 +0000 MIME-Version: 1.0 Date: Thu, 28 Jan 2021 09:02:14 +0000 From: Marc Zyngier To: "Biwen Li (OSS)" Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace In-Reply-To: References: <20210127085818.23742-1-biwen.li@oss.nxp.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <6e20a326ebffdb6768a95c15ac743759@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: biwen.li@oss.nxp.com, mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org, ran.wang_1@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_040217_586453_9D03B250 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-kernel@vger.kernel.org, Leo Li , Jiafei Pan , Ran Wang , tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMS0yOCAwMjozNywgQml3ZW4gTGkgKE9TUykgd3JvdGU6Cj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4+ IFNlbnQ6IDIwMjHlubQx5pyIMjfml6UgMTk6MzgKPj4gVG86IEJpd2VuIExpIChPU1MpIDxiaXdl bi5saUBvc3MubnhwLmNvbT4KPj4gQ2M6IG1hcmsucnV0bGFuZEBhcm0uY29tOyBMZW8gTGkgPGxl b3lhbmcubGlAbnhwLmNvbT47IAo+PiB0Z2x4QGxpbnV0cm9uaXguZGU7Cj4+IGphc29uQGxha2Vk YWVtb24ubmV0OyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBKaWFmZWkgUGFuCj4+IDxq aWFmZWkucGFuQG54cC5jb20+OyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7 IFJhbiBXYW5nCj4+IDxyYW4ud2FuZ18xQG54cC5jb20+OyBCaXdlbiBMaSA8Yml3ZW4ubGlAbnhw LmNvbT4KPj4gU3ViamVjdDogUmU6IFt2Ml0gaXJxY2hpcDogbHMtZXh0aXJxOiBhZGQgZmxhZyBJ UlFDSElQX1NLSVBfU0VUX1dBS0UgCj4+IHRvCj4+IHJlbW92ZSBjYWxsIHRyYWNlCj4+IAo+PiBP biAyMDIxLTAxLTI3IDA4OjU4LCBCaXdlbiBMaSB3cm90ZToKPj4gPiBGcm9tOiBCaXdlbiBMaSA8 Yml3ZW4ubGlAbnhwLmNvbT4KPj4gPgo+PiA+IEFkZCBmbGFnIElSUUNISVBfU0tJUF9TRVRfV0FL RSB0byByZW1vdmUgY2FsbCB0cmFjZSBhcyBmb2xsb3csIC4uLgo+PiA+IFsgICA0NS42MDUyMzld IFVuYmFsYW5jZWQgSVJRIDEyMCB3YWtlIGRpc2FibGUKPj4gPiBbICAgNDUuNjA5NDQ1XSBXQVJO SU5HOiBDUFU6IDAgUElEOiAxMTI0IGF0IGtlcm5lbC9pcnEvbWFuYWdlLmM6ODAwCj4+ID4gaXJx X3NldF9pcnFfd2FrZSsweDE1NC8weDFhMAo+PiA+IC4uLgo+PiA+IFsgICA0NS42NDUxNDFdIHBz dGF0ZTogNjAwMDAwODUgKG5aQ3YgZGFJZiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkKPj4gPiBb ICAgNDUuNjUxMTQ0XSBwYyA6IGlycV9zZXRfaXJxX3dha2UrMHgxNTQvMHgxYTAKPj4gPiBbICAg NDUuNjU1NDk3XSBsciA6IGlycV9zZXRfaXJxX3dha2UrMHgxNTQvMHgxYTAKPj4gPiAuLi4KPj4g PiBbICAgNDUuNzQyODI1XSBDYWxsIHRyYWNlOgo+PiA+IFsgICA0NS43NDUyNjhdICBpcnFfc2V0 X2lycV93YWtlKzB4MTU0LzB4MWEwCj4+ID4gWyAgIDQ1Ljc0OTI3OF0gIGRzMzIzMl9yZXN1bWUr MHgzOC8weDUwCj4+ID4KPj4gPiBPbiBsczIwODhhcmRiOgo+PiA+IEluIHN1c3BlbmQgcHJvZ3Jl c3MoIyBlY2hvIG1lbSA+IC9zeXMvcG93ZXIvc3RhdGUpLAo+PiA+Cj4+IHBtX3N1c3BlbmQoKS0+ c3VzcGVuZF9kZXZpY2VzX2FuZF9lbnRlcigpLT5kcG1fc3VzcGVuZCgpLT5kZXZpY2Vfc3VzcGUK Pj4gPiBuZCgpCj4+ID4gLT5kczMyMzJfc3VzcGVuZCgpLT5lbmFibGVfaXJxX3dha2UoKS0+aXJx X3NldF9pcnFfd2FrZSgpCj4+ID4gLT5zZXRfaXJxX3dha2VfcmVhbCgpLCByZXR1cm4gLUVOWElP LCB0aGVyZSBnZXQKPj4gPiAiQ2Fubm90IHNldCB3YWtldXAgc291cmNlIiBpbiBkczMyMzJfc3Vz cGVuZCgpLgo+PiA+Cj4+ID4gSW4gcmVzdW1lIHByb2dyZXNzKHdha2V1cCBieSBmbGV4dGltZXIp Cj4+ID4gZHBtX3Jlc3VtZV9lbmQoKS0+ZHBtX3Jlc3VtZSgpCj4+ID4gLT5kZXZpY2VfcmVzdW1l KCktPmRzMzIzMl9yZXN1bWUoKQo+PiA+IC0+ZGlzYWJsZV9pcnFfd2FrZSgpLT5pcnFfc2V0X2ly cV93YWtlKCkKPj4gPiAtPnNldF9pcnFfd2FrZV9yZWFsKCksIHRoZXJlIGdldAo+PiA+IGtlcm5l bCBjYWxsIHRyYWNlKFVuYmFsYW5jZWQgSVJRIDEyMCB3YWtlCj4+ID4gZGlzYWJsZSkKPj4gCj4+ IFRoaXMgaXMgYWdhaW4gcGFyYXBocmFzaW5nIHRoZSBzdGFjayB0cmFjZSBpbnN0ZWFkIG9mIGV4 cGxhaW5pbmcgdGhlIAo+PiBwcm9ibGVtIGl0Cj4+IGZpeGVzLiBIb3cgYWJvdXQ6Cj4+IAo+PiAi VGhlIGxzLWV4dGlycSBkcml2ZXIgZG9lc24ndCBpbXBsZW1lbnQgdGhlIGlycV9zZXRfd2FrZSgp Cj4+ICAgY2FsbGJhY2ssIHdoaWxlIGJlaW5nIHdha2UtdXAgY2FwYWJsZS4gVGhpcyByZXN1bHRz IGluCj4+ICAgdWdseSBiZWhhdmlvdXJzIGFjcm9zcyBzdXNwZW5kL3Jlc3VtZSBjeWNsZXMuCj4+ IAo+PiAgIEFkdmVydGlzZSB0aGlzIGJ5IGFkZGluZyBJUlFDSElQX1NLSVBfU0VUX1dBS0UgdG8g dGhlIGlycWNoaXAKPj4gICBmbGFncyIKPj4gCj4+IFRoZSBzdWJqZWN0IGxpbmUgc2hvdWxkIGJl IGZpeGVkIGFsb25nIHRoZSBzYW1lIGxpbmVzLCBhbmQgYSBGaXhlczogCj4+IHRhZyBhZGRlZC4K PiBPa2F5LCBnb3QgaXQuIFRoYW5rcy4gV2lsbCB1cGRhdGUgaW4gdjMuCgouLi4gYW5kIHYzIHN0 aWxsIGRvZXNuJ3QgaGF2ZSBhIEZpeGVzOiB0YWcuCgpGcmFua2x5LCBpZiB5b3UgY2FuJ3QgYmUg Ym90aGVyZWQgdG8gZG8gdGhpcywgd2h5IHNob3VsZCBJIHdvcnJ5CmFib3V0IHlvdXIgcGxhdGZv cm0gYmVpbmcgYnJva2VuPwoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1 c3Qgc21lbGxzIGZ1bm55Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938FEC433E0 for ; Thu, 28 Jan 2021 09:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4565464DD6 for ; Thu, 28 Jan 2021 09:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231546AbhA1JBe (ORCPT ); Thu, 28 Jan 2021 04:01:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:49522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbhA1JBc (ORCPT ); Thu, 28 Jan 2021 04:01:32 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BF1664DD6; Thu, 28 Jan 2021 09:02:16 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l53Bu-00AZWy-Bo; Thu, 28 Jan 2021 09:02:14 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 28 Jan 2021 09:02:14 +0000 From: Marc Zyngier To: "Biwen Li (OSS)" Cc: mark.rutland@arm.com, Leo Li , tglx@linutronix.de, linux-kernel@vger.kernel.org, Jiafei Pan , linux-arm-kernel@lists.infradead.org, Ran Wang Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace In-Reply-To: References: <20210127085818.23742-1-biwen.li@oss.nxp.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <6e20a326ebffdb6768a95c15ac743759@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: biwen.li@oss.nxp.com, mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org, ran.wang_1@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-28 02:37, Biwen Li (OSS) wrote: >> -----Original Message----- >> From: Marc Zyngier >> Sent: 2021年1月27日 19:38 >> To: Biwen Li (OSS) >> Cc: mark.rutland@arm.com; Leo Li ; >> tglx@linutronix.de; >> jason@lakedaemon.net; linux-kernel@vger.kernel.org; Jiafei Pan >> ; linux-arm-kernel@lists.infradead.org; Ran Wang >> ; Biwen Li >> Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE >> to >> remove call trace >> >> On 2021-01-27 08:58, Biwen Li wrote: >> > From: Biwen Li >> > >> > Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ... >> > [ 45.605239] Unbalanced IRQ 120 wake disable >> > [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 >> > irq_set_irq_wake+0x154/0x1a0 >> > ... >> > [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) >> > [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0 >> > [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0 >> > ... >> > [ 45.742825] Call trace: >> > [ 45.745268] irq_set_irq_wake+0x154/0x1a0 >> > [ 45.749278] ds3232_resume+0x38/0x50 >> > >> > On ls2088ardb: >> > In suspend progress(# echo mem > /sys/power/state), >> > >> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspe >> > nd() >> > ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake() >> > ->set_irq_wake_real(), return -ENXIO, there get >> > "Cannot set wakeup source" in ds3232_suspend(). >> > >> > In resume progress(wakeup by flextimer) >> > dpm_resume_end()->dpm_resume() >> > ->device_resume()->ds3232_resume() >> > ->disable_irq_wake()->irq_set_irq_wake() >> > ->set_irq_wake_real(), there get >> > kernel call trace(Unbalanced IRQ 120 wake >> > disable) >> >> This is again paraphrasing the stack trace instead of explaining the >> problem it >> fixes. How about: >> >> "The ls-extirq driver doesn't implement the irq_set_wake() >> callback, while being wake-up capable. This results in >> ugly behaviours across suspend/resume cycles. >> >> Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip >> flags" >> >> The subject line should be fixed along the same lines, and a Fixes: >> tag added. > Okay, got it. Thanks. Will update in v3. ... and v3 still doesn't have a Fixes: tag. Frankly, if you can't be bothered to do this, why should I worry about your platform being broken? M. -- Jazz is not dead. It just smells funny...